[fm] fm-rest-api/fm/fm/common/timeutils.py should be replaced by oslo.utils.timeutils.

Bug #1859737 reported by Yan Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Yan Chen

Bug Description

According to review comments from https://review.opendev.org/#/c/702327/, we should remove fm-rest-api/fm/fm/common/timeutils.py, and use oslo.utils.timeutils instead.

Yan Chen (ychen2u)
Changed in starlingx:
assignee: nobody → Yan Chen (ychen2u)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fault (master)

Fix proposed to branch: master
Review: https://review.opendev.org/702589

Changed in starlingx:
status: New → In Progress
Revision history for this message
Ghada Khalil (gkhalil) wrote :

stx.4.0 / medium priority - code cleanup suggested by core reviewers

Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.4.0 stx.fault
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fault (master)

Reviewed: https://review.opendev.org/702589
Committed: https://git.openstack.org/cgit/starlingx/fault/commit/?id=79a90ab97954c5cd89c17703044371746f74b71a
Submitter: Zuul
Branch: master

commit 79a90ab97954c5cd89c17703044371746f74b71a
Author: chenyan <email address hidden>
Date: Wed Jan 15 15:41:04 2020 +0800

    Remove fm/common/timeutils.

    Replace fm/common/timeutils with oslo_utils.timeutils

    Closes-Bug: 1859737

    Depends-on: https://review.opendev.org/#/c/702347/
    Change-Id: I35697d6e516c0b06bea76babb91e43f45e000650
    Signed-off-by: chenyan <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fault (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/705846

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fault (f/centos8)

Reviewed: https://review.opendev.org/705846
Committed: https://git.openstack.org/cgit/starlingx/fault/commit/?id=b5673f078b6daf61ee054ca3075dc5af71b3ef1a
Submitter: Zuul
Branch: f/centos8

commit 6f0ed2e8fdf202cd35698403ea07eb5242fdb683
Author: Kristal Dale <email address hidden>
Date: Wed Jan 15 15:00:08 2020 -0800

    Update landing pages for docs, api-ref, and release notes:

    - Use updated project name in titles/text
    - Correct text for link to Storyboard (docs)
    - Correct capitalization in section headings
    - Correct formatting for section headings
    - Update project name in link to release notes, api-ref
    - Update project name in config for docs/releasenotes/api-ref

    Story:2007193
    Task:38337

    Change-Id: I03de3548572d3b5f2f68cfa6105ed876c973b5e6
    Signed-off-by: Kristal Dale <email address hidden>

commit 1b555beaa8b8af1977ba9f1b8cb1f61fbf0cb1dd
Author: chenyan <email address hidden>
Date: Wed Jan 15 15:22:52 2020 +0800

    Remove fm.common.utils.generate_uuid.

    Replace fm-rest-api fm.common.utils.generate_uuid with
    oslo_utils.uuidutils.generate_uuid.

    Closes-Bug: 1859738

    Depends-on: https://review.opendev.org/#/c/702347/
    Change-Id: I31e1ec1c0605707697f03446b1e04eec5063c5f3
    Signed-off-by: chenyan <email address hidden>

commit 79a90ab97954c5cd89c17703044371746f74b71a
Author: chenyan <email address hidden>
Date: Wed Jan 15 15:41:04 2020 +0800

    Remove fm/common/timeutils.

    Replace fm/common/timeutils with oslo_utils.timeutils

    Closes-Bug: 1859737

    Depends-on: https://review.opendev.org/#/c/702347/
    Change-Id: I35697d6e516c0b06bea76babb91e43f45e000650
    Signed-off-by: chenyan <email address hidden>

commit 2f37da8e8e90ec9135f7cd88d6187297d69e3e86
Author: chenyan <email address hidden>
Date: Tue Jan 14 14:06:44 2020 +0800

    Add unit test case for fm-rest-api/fm/fm/common/utils.py

    Add test case FaultUtilsTestCase.
    Add fake log in tests/base.py.

    Story: 2007082
    Task: 38093
    Task: 38084

    Depends-on: https://review.opendev.org/#/c/702175/
    Change-Id: I560415ed1519834c21f0090f594f2da6c26f3eca
    Signed-off-by: chenyan <email address hidden>

commit 385f274a8fb3a9c5d9a21ed59273d87e17c9e07c
Author: chenyan <email address hidden>
Date: Mon Jan 13 15:02:48 2020 +0800

    Create test framework for python with stestr.

    Add add the first unit test for fm-rest-api/fm/fm/common/timeutils.
    Add tox task for py27/35 as zuul checking and gating jobs.

    Story: 2007082
    Task: 38077

    Change-Id: I2f259dcf2178f42546966063c0d724bc17e2a804
    Signed-off-by: chenyan <email address hidden>

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.