Inconsistent unit of measure for journal size in system host-stor-update command
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Won't Fix
|
Low
|
Mihnea Saracin |
Bug Description
Brief Description
-----------------
Inconsistent cli journal size unit of measure in the system host-stor command (GiB used in most places but system host-stor-update using MiB)
Severity
--------
standard
Steps to Reproduce
------------------
Confirm consistent output in GiB for the journal size in the system host-stor commands
1. The size is in GiB in host-stor-list
$ system host-stor-list controller-0
+------
| uuid | function | osdid | state | idisk_uuid | journal_path | journal_no | journal_ | tier_name |
| | | | | | | de | size_gib | |
+------
| 4f2a6d16-
| | | | | | 00:1f.2-
| | | | | | | | | |
+------
2. The size is in GiB in host-stor-add
$ system host-stor-add
usage: system host-stor-add [--journal-location [<journal_
system host-stor-add: error: too few arguments
$ system help host-stor-add
usage: system host-stor-add [--journal-location [<journal_
Add a storage to a host.
Positional arguments:
<hostname or id> Name or ID of host [REQUIRED]
<function> Type of the stor (default: osd)
<idisk_uuid> uuid of disk [REQUIRED]
Optional arguments:
--journal-
--journal-size [<size of the journal (GiB)>]
--tier-uuid [<storage tier uuid>]
3.
$ system host-stor-update --journal-location 4f2a6d16-
usage: system host-stor-update [--journal-location [<journal_
system host-stor-update: error: too few arguments
$ system help host-stor-update
usage: system host-stor-update [--journal-location [<journal_
Modify journal attributes for OSD.
Positional arguments:
<osd stor uuid> UUID of osd[REQUIRED]
Optional arguments:
--journal-
--journal-size [<size of the journal (MiB)>]
4. $ system host-stor-update --journal-location cbfbf28f-
+------
| Property | Value |
+------
| osdid | 1 |
| function | osd |
| state | configuring-
| journal_location | cbfbf28f-
| journal_size_gib | 10240 |
| journal_path | /dev/disk/
| journal_node | /dev/nvme1n1p1 |
| uuid | 3f9a6686-
| ihost_uuid | b3f5dd04-
| idisk_uuid | eff63bd4-
| tier_uuid | f4626531-
| tier_name | storage |
| created_at | 2019-11-
| updated_at | 2019-11-
Expected Behavior
------------------
Expect the journal size to consistently use the same units of measure (ie. GiB) thoughout for system host-stor commands
Actual Behavior
----------------
In step 3 and 4, there are inconsistencies in the unit representation for the journal size on $system host-stor-update operations.
eg.
system host-stor-update command in still using the units MiB
update command specifies 10 but it is converted to 10240
Reproducibility
---------------
100%
System Configuration
-------
Storage
Branch/Pull Time/Commit
-------
2019-11-11_20-00-00 (or 2019-12-
description: | updated |
tags: | added: stx.4.0 stx.config stx.storage |
Changed in starlingx: | |
assignee: | nobody → Mihnea Saracin (msaracin) |
tags: | added: stx.retestneeded |
stx.4.0 / medium priority - inconsistency with storage system cli cmds