Comment 9 for bug 1858216

Reviewed: https://review.opendev.org/702033
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=76addb37b281fccf1e39bbebcd6bec88bfb4c362
Submitter: Zuul
Branch: r/stx.3.0

commit 76addb37b281fccf1e39bbebcd6bec88bfb4c362
Author: Eric MacDonald <email address hidden>
Date: Fri Jan 3 14:28:28 2020 -0500

    Fix MNFA timer timeout condition check

    A timer module change made in https://review.opendev.org/#/c/698311
    introduced a change that makes all unstarted/stopped timers appear
    as expired/rung.

    A MNFA (Multi Node Failure Avoidance) timeout of zero represents no
    timeout and is implemented by not starting a timer for that condition.

    However, due to the recent change, that makes the MNFA timer expiry
    check succeed immediatly causing MNFA to exit prematurely causing the
    issue reported by the Bug reference.

    The fix is to condition the timer expiry check with a non-zero MNFA
    timeout value.

    Test Plan:

    PASS: Verify MNFA handling with and without timeout.
    PASS: Verify 3 node MNFA handling due to node power cycle
    PASS: Verify 2 node MNFA handling and recovery due to cable pull

    Change-Id: I97363cd309f786b3d41288667d4378b91e4a0d23
    Closes-Bug: 1858216
    Signed-off-by: Eric MacDonald <email address hidden>
    (cherry picked from commit e86d0b915896b74cb6956d93e99b5dd308271e80)