build-pkgs --edit should use git am to apply patches
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Triaged
|
Low
|
Frank Miller |
Bug Description
Brief Description
-----------------
When using build-pkgs --edit, patches are applied by the tool to the source using "patch -p1 ....", and then committed using a horrible shortlog, and any long log commit header entries are completely lost. This makes build-pkgs --edit almost completely useless to anybody looking to modify existing patches. I consider this lack of utility to be a bug. We've been living with this for far too long now.
build-pkgs --edit should first try to apply patches via "git am", and failing that then fallback to "patch -p1 ...." as there are some non git formatted patches in some of our packages (would be nice to find them and get a commit header onto them). Or maybe better yet, first check to see if the patch has a git commit header on it and if so, then use git am to apply it.
Severity
--------
Major: System/Feature is usable but degraded
Steps to Reproduce
------------------
build-pkgs --edit kernel (or other package that we build that has patches against it)
Expected Behavior
------------------
You get a source repo containing commits with the commit headers preserved from the patches.
Actual Behavior
----------------
You get a source repo containing commits with munged headers.
Reproducibility
---------------
100%
System Configuration
-------
N/A it's in the build tool
Branch/Pull Time/Commit
-------
It has been like this from day one.
Last Pass
---------
N/A
Timestamp/Logs
--------------
N/A
Test Activity
-------------
N/A
Workaround
----------
Hard reset the repos and apply the patch sequences manually via git am
tags: | added: stx.build |
Assigning to the stx.build PL for triage/follow-up