update-iso.sh corrupts grub.cfg timeout on update to previously updated ISO

Bug #1856764 reported by Don Penney
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Don Penney

Bug Description

Brief Description
-----------------
When using update-iso.sh to update a previously updated ISO, the grub.cfg timeout command-line gets corrupted due to a bug in the utility.

Severity
--------
Major: System/Feature is usable but degraded

Reproducibility
---------------
Reproducible

Branch/Pull Time/Commit
-----------------------
master, as of 12/17/2019

Test Activity
-------------
Developer Testing

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to utilities (master)

Reviewed: https://review.opendev.org/699508
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=f7886f995007789cea898066e6b9f34918fec967
Submitter: Zuul
Branch: master

commit f7886f995007789cea898066e6b9f34918fec967
Author: Don Penney <email address hidden>
Date: Tue Dec 17 16:53:46 2019 -0500

    Fix update-iso.sh handling of existing timeout in grub.cfg

    Fix a bug where the submenu timeout is corrupted by an incorrect sed
    command.

    In addition, update handling of 0 second timeout to set the timeout in
    grub.cfg to 0.001, to avoid issues on some systems with timeout=0.

    Change-Id: I0683f39eb906da512cacc77bde28f8420a73a001
    Closes-Bug: 1856764
    Signed-off-by: Don Penney <email address hidden>

Changed in starlingx:
status: New → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
assignee: nobody → Don Penney (dpenney)
Revision history for this message
Ghada Khalil (gkhalil) wrote :

stx.4.0 / medium priority - issue can be avoided by using the update-iso.sh on an unmodified iso only. Therefore, no plan to cherrypick to r/stx.3.0 at this time

tags: added: stx.build stx.tools
tags: added: stx.4.0
Changed in starlingx:
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.