stx-monitor download_images incorrect in stx-monitor-images.yaml

[John Kung]

Brief Description
-----------------
The download_images list created on application-upload contains newly (unreferenced) images and is missing
image.

Severity
--------
Provide the severity of the defect.

Major/Critical: Feature usable with workarounds to download and tag docker images

Steps to Reproduce
------------------

system application-upload stx-monitor-1.0-1.tgz
system application-apply stx-monitor
<fails to download images; or application missing image>

/opt/platform/armada/.../stx-monitor/1.0-1/stx-monitor-images.yaml

Expected Behavior
------------------
The list minimally must contain the following, which stx-monitor is dependent on:
download_images:
- registry.local:9001/quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.23.0
- registry.local:9001/docker.elastic.co/elasticsearch/elasticsearch-oss:7.4.0
- registry.local:9001/docker.elastic.co/logstash/logstash-oss:7.4.0
- registry.local:9001/docker.elastic.co/kibana/kibana-oss:7.4.0
- registry.local:9001/docker.elastic.co/beats/filebeat-oss:7.4.0
- registry.local:9001/docker.io/untergeek/curator:5.7.6
- registry.local:9001/docker.io/trustpilot/beat-exporter:0.1.1
- registry.local:9001/docker.elastic.co/beats/metricbeat-oss:7.4.0
- registry.local:9001/quay.io/coreos/kube-state-metrics:v1.8.0
- registry.local:9001/k8s.gcr.io/defaultbackend:1.4

Actual Behavior
----------------
The list observed contains:
download_images:
- registry.local:9001/docker.io/bonniernews/logstash_exporter:v0.1.2
- registry.local:9001/docker.elastic.co/elasticsearch/elasticsearch-oss:7.4.0
- registry.local:9001/docker.elastic.co/logstash/logstash-oss:7.4.0
- registry.local:9001/docker.elastic.co/kibana/kibana-oss:7.4.0
- registry.local:9001/trustpilot/beat-exporter:0.1.1
- registry.local:9001/docker.elastic.co/beats/filebeat-oss:7.4.0
- registry.local:9001/docker.io/untergeek/curator:5.7.6
- registry.local:9001/docker.io/dduportal/bats:0.4.0
- registry.local:9001/docker.elastic.co/beats/metricbeat-oss:7.4.0
- registry.local:9001/quay.io/coreos/kube-state-metrics:v1.8.0
- registry.local:9001/quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.23.0

It is missing: k8s.gcr.io/defaultbackend:1.4
It adds: dduportal/bats:0.4.0; logstash_exporter:v0.1.2 (which isnt needed), and potentially also /dwdraju/alpine-curl-jq:latest.

Reproducibility
---------------
Intermittent

System Configuration
--------------------
Two Node, Virtual Box

Branch/Pull Time/Commit
-----------------------
2019-12-09_20-00-00

Last Pass
---------
This passed previously in another lab: 2019-12-06_20-00-00

Logs
---
See the output of /opt/platform/armada/.../stx-monitor/1.0-1/stx-monitor-images.yaml
noted above.

Test Activity
-------------
Regression Testing, Developer Testing

[Kevin Smith (kevin.smith.wrs)]

My feeling is the additional images now specified for download are correct, as in general there may be optional functionality present in charts that may spin up a container using a specified image. It is debatable about the test images however, as there is currently no way that I know of to override the armada manifest test settings for a chart.

The missing nginx defaultbackend image in the download images list is however a definite issue.

For the time being, I will patch out the unneeded/unused charts and explicitly reference the nginx defaultbackend image in the manifest.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698780

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698780
Committed: https://git.openstack.org/cgit/starlingx/monitor-armada-app/commit/?id=f6010f4ed211817a0f0fab8ef9aa175085068f0e
Submitter: Zuul
Branch: master

commit f6010f4ed211817a0f0fab8ef9aa175085068f0e
Author: Kevin Smith <email address hidden>
Date: Thu Dec 12 13:08:44 2019 -0500

    Remove unused image references from monitor app

    Remove all references to images that are not used by the app
    to prevent downloading them. Removals include images for
    testing kibana and enabling logstash exporter.

    Also explicitly add a reference to the nginx defaultbackend image
    in the manifest as it fails to appear in the image download
    list in the application images yaml file. This is possibly an
    image parsing issue to be looked at later.

    Change-Id: Id6ec19e6c8e5df4aa543a3e4f6b3c36b954d0971
    Partial-Bug: 1856197
    Signed-off-by: Kevin Smith <email address hidden>

[Ghada Khalil (gkhalil)]

stx.3.0 / high priority - issue will result in the failure to apply the stx-monitor application and requires manual steps. Target to fix in an upcoming stx.3.0 maintenance release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.3.0
Review: https://review.opendev.org/702739

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702739
Committed: https://git.openstack.org/cgit/starlingx/monitor-armada-app/commit/?id=e5ee6b3a07b74479b93fe90eff0662cf81890f73
Submitter: Zuul
Branch: r/stx.3.0

commit e5ee6b3a07b74479b93fe90eff0662cf81890f73
Author: Kevin Smith <email address hidden>
Date: Thu Dec 12 13:08:44 2019 -0500

    Remove unused image references from monitor app

    Remove all references to images that are not used by the app
    to prevent downloading them. Removals include images for
    testing kibana and enabling logstash exporter.

    Also explicitly add a reference to the nginx defaultbackend image
    in the manifest as it fails to appear in the image download
    list in the application images yaml file. This is possibly an
    image parsing issue to be looked at later.

    Change-Id: Id6ec19e6c8e5df4aa543a3e4f6b3c36b954d0971
    Partial-Bug: 1856197
    Signed-off-by: Kevin Smith <email address hidden>
    (cherry picked from commit f6010f4ed211817a0f0fab8ef9aa175085068f0e)