Cleanup invalid log

[Brent Rowsell]

Brief Description
-----------------
Following daemon log generated every 10 secs on systems without ovs (i.e. kubernetes only deployment)

2019-12-08T15:01:20.000 controller-0 collectd[121715]: info ovs interface plugin failed to initial because pid file for ovs-vswitchd doesn't exist

Severity
--------
Very minor

Steps to Reproduce
------------------
Steady state

Expected Behavior
------------------
No log should be generated if ovs is not deployed

Actual Behavior
----------------
Log is generated

Reproducibility
---------------
100%

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
BUILD_DATE="2019-12-04 14:57:54 -0500"

Last Pass
---------
Don't know

Timestamp/Logs
--------------
2019-12-08T15:01:20.000 controller-0 collectd[121715]: info ovs interface plugin failed to initial because pid file for ovs-vswitchd doesn't exist

Test Activity
-------------
Developer Testing

[Ghada Khalil (gkhalil)]

Low priority - error log generated from the collectd config when vswitch = none

[Ghada Khalil (gkhalil)]

correction ...log generated when vswitch != ovs-dpdk

[Eric MacDonald (rocksolidmtce)]

I have an update that was developed for what turned out to be a duplicate of this issue.
Said update is ready to go. Just need to test the stx-openstack config.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707872
Committed: https://git.openstack.org/cgit/starlingx/monitoring/commit/?id=4ab570a850f7a2f6143e5af6c6422cd0bc694f88
Submitter: Zuul
Branch: master

commit 4ab570a850f7a2f6143e5af6c6422cd0bc694f88
Author: Eric MacDonald <email address hidden>
Date: Fri Jan 31 19:10:57 2020 -0500

    Throttle collectd OVS interface plugin startup wait log

    This update turns a flooding failure log into a single
    waiting log while the collectd OVS interface plugin
    initialization sequence waits for a running ovs daemon.

    A few pep8 long line warning are fixed.

    Test Plan:

    PASS: Verify plugin behavior of compute system install without Openstack
    PASS: Verify plugin behavior in AIO-SX with Openstack
    PASS: Verify plugin failure handling and recovery with Openstack
                 Note: the ovs-vswitch pmon conf file was changed to allow
                 process failure recovery to verify the plugin was able to
                 handle transition from not running/waiting to running once
                 process started.
    PASS: Verify plugin failure handling when ovs-vswitchd process fails.
                 Note: pmond does not try and recover and the following
                 collectd log is produced every 10 seconds.
                 'err ovs interface plugin failed to dump ports br-phy1 desc'

    Change-Id: I95d308f771ebabc77dbeb5113feae283538d37d3
    Closes-Bug: 1855597
    Signed-off-by: Eric MacDonald <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/716149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716149
Committed: https://git.openstack.org/cgit/starlingx/monitoring/commit/?id=dd35fc9dc1e96756a55c7cd71356dd7acba2e06c
Submitter: Zuul
Branch: f/centos8

commit 4ab570a850f7a2f6143e5af6c6422cd0bc694f88
Author: Eric MacDonald <email address hidden>
Date: Fri Jan 31 19:10:57 2020 -0500

    Throttle collectd OVS interface plugin startup wait log

    This update turns a flooding failure log into a single
    waiting log while the collectd OVS interface plugin
    initialization sequence waits for a running ovs daemon.

    A few pep8 long line warning are fixed.

    Test Plan:

    PASS: Verify plugin behavior of compute system install without Openstack
    PASS: Verify plugin behavior in AIO-SX with Openstack
    PASS: Verify plugin failure handling and recovery with Openstack
                 Note: the ovs-vswitch pmon conf file was changed to allow
                 process failure recovery to verify the plugin was able to
                 handle transition from not running/waiting to running once
                 process started.
    PASS: Verify plugin failure handling when ovs-vswitchd process fails.
                 Note: pmond does not try and recover and the following
                 collectd log is produced every 10 seconds.
                 'err ovs interface plugin failed to dump ports br-phy1 desc'

    Change-Id: I95d308f771ebabc77dbeb5113feae283538d37d3
    Closes-Bug: 1855597
    Signed-off-by: Eric MacDonald <email address hidden>

commit e74efea7fe7c7de8d9d447a5e2701c5ebf9d25e2
Author: David Sullivan <email address hidden>
Date: Fri Feb 14 15:55:24 2020 -0500

    Support non-zero domains

    Update the ptp extension to use the ptp4l conf during pmc commands. This
    will allow the collectd extension to work when a non-zero domain is
    specified.

    Change-Id: Ied0fad0e1ef2998d791619df4e9a548d3d9a3f18
    Story: 2006759
    Task: 38772
    Signed-off-by: David Sullivan <email address hidden>

commit 93543d708f7eefb119bdaabbaf20665408cabb21
Author: Bin Qian <email address hidden>
Date: Fri Feb 7 10:12:52 2020 -0500

    Trigger upload job to upload repo to GitHub

    Trigger upload job to upload repo to GitHub
    No code change

    Story: 2007252
    Task: 38688

    Change-Id: I4278ca1ed441495eede7cd98e303d212e4c3cac2
    Signed-off-by: Bin Qian <email address hidden>

commit 9c4140c868240a1701303ace98c0ca4620494110
Author: Bin Qian <email address hidden>
Date: Thu Feb 6 12:16:31 2020 -0500

    Adding job to upload commits to GitHub

    Add job to publish monitoring repo to GitHub

    Change-Id: Id6b7a64b5fa45b487b5004c0f8bc29380bff2371
    Story: 2007252
    Task: 38688
    Signed-off-by: Bin Qian <email address hidden>

commit 02b1d056ee49db655dd72af2586f537b0c56d7c7
Author: marvin <email address hidden>
Date: Tue Nov 19 16:26:43 2019 +0800

    Monitor the data network for non-OpenStack worker nodes

    Update the lmon to support datanetwork interface monitoring
    and use collectd to control the alarm information. Now lmon
    will obtain the list of interfaces from...