Patch Orchestration should not enforce openstack specific criteria

[Brent Rowsell]

On a kubernetes only deployment, patch orchestration will fail on a simplex system using the default strategy arguments.

subcloud3 | 2 | failed | Strategy build failed for subcloud3 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.333676 | 2019-12-01 03:07:08.147827 |
| subcloud4 | 2 | failed | Strategy build failed for subcloud4 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.337855 | 2019-12-01 03:07:10.604601 |
| subcloud1 | 2 | failed | Strategy build failed for subcloud1 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.346228 | 2019-12-01 03:07:10.673850 |
| subcloud5 | 2 | failed | Strategy build failed for subcloud5 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.355060 | 2019-12-01 03:07:10.751670 |
| subcloud2 | 2 | failed | Strategy build failed for subcloud2 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.362815 | 2019-12-01 03:06:58.327315 |
| subcloud8 | 2 | failed | Strategy build failed for subcloud8 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.370288 | 2019-12-01 03:07:10.843620 |
| subcloud7 | 2 | failed | Strategy build failed for subcloud7 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.377886 | 2019-12-01 03:06:58.260544 |
| subcloud6 | 2 | failed | Strategy build failed for subcloud6 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.386576 | 2019-12-01 03:07:10.512539 |
| subcloud9 | 2 | failed | Strategy build failed for subcloud9 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.395325 | 2019-12-01 03:07:16.862763 |
| subcloud10 | 2 | failed | Strategy build failed for subcloud10 - cannot migrate instances in a single controller configuration | 2019-12-01 03:06:25.404450 | 2019-12-01 03:07:17.326004 |

Migration in general is not applicable in this case and patch orchestration should simply ignore.

[Ghada Khalil (gkhalil)]

This was previously reported in: https://bugs.launchpad.net/starlingx/+bug/1848749 and marked as Invalid by Bart Wensley with the following comment:
"
For simplex subclouds, you must change the configuration to set the default_instance_action to stop-start (since migration is not possible on a single-node system).
"

Is the request to change the default for simplex?

[Dariush Eslimi (deslimi)]

Talked to Brent, and we do not want default to change.
The parms that are not applicable should be ignored .
Migration is irrelevant for k8s.

[Ghada Khalil (gkhalil)]

Not gating for stx.3.0 given there is a way to get around this

[Bart Wensley (bartwensley)]

This is a different issue - in the case where the stx-openstack application is not installed on a subcloud, the VIM should be ignoring any configuration related to OpenStack instances.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697073

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697073
Committed: https://git.openstack.org/cgit/starlingx/nfv/commit/?id=3cdea4f02b655680cae5815709db388cf7405075
Submitter: Zuul
Branch: master

commit 3cdea4f02b655680cae5815709db388cf7405075
Author: Bart Wensley <email address hidden>
Date: Tue Dec 3 06:50:38 2019 -0600

    Ignore instance action for non-OpenStack worker hosts

    When a patch orchestration strategy is created by the dcmanager,
    the default instance action is set to migrate to minimize the
    impact to any OpenStack instances (VMs) that may be running.
    However, on simplex subclouds, the migrate instance action is
    rejected, since there is nowhere to migrate these instances.
    The user can override this default, but for non-OpenStack
    subclouds, the default instance action is not applicable and
    should be ignored by the VIM so the user does not need to
    change it.

    Updating the VIM to ignore the instance action for simplex hosts
    that do not have OpenStack installed.

    Change-Id: I70984b1042f4460fd8a8e621e44756f022df03d7
    Closes-Bug: 1854655
    Signed-off-by: Bart Wensley <email address hidden>

[Ghada Khalil (gkhalil)]

Confirmed with Bart that the workaround to use stop-start action is valid.