Distributed Cloud - patch vault missing from aio system controller deployment

[Brent Rowsell]

Brief Description
-----------------
The /opt/patch-vault filesystem is not created for AIO system controller deployments. It needs to be available for all system controller deployments.

Otherwise this can cause the rootfs to get filled up with patches over time.

Severity
--------
Medium

Steps to Reproduce
---------
Install and configure a distributed cloud system w/ AIO system controller

Expected Behavior
---------
The patch-vault file system should be created.

Actual Behavior
----------------
The patch-vault file system is not created.

Reproducibility
---------
100%

System Configuration
---------
Distributed Cloud system w/ AIO system controller

Branch/Pull Time/Commit
---------
stx master -- any recent load

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
System install

[Ghada Khalil (gkhalil)]

stx.3.0 / medium priority - can cause potential issue over time

[Frank Miller (sensfan22)]

It looks like the original code that added this filesystem for Distributed Cloud assumed AIO would not be used for Distributed Cloud. This is no longer the case. We will need to implement a change to support the/opt/patch-vault filesystem on an AIO system controller for Distributed Cloud.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697706

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697706
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=a8e6745ae238a3b44a750ddad289192c29898547
Submitter: Zuul
Branch: master

commit a8e6745ae238a3b44a750ddad289192c29898547
Author: Dan Voiculeasa <email address hidden>
Date: Fri Dec 6 18:28:51 2019 +0000

    Enable AIO Distributed Cloud patch vault

    Let /opt/patch-vault be mounted on AIO platform.

    Closes-Bug: 1853356
    Change-Id: If6e91cee5494c52f5da00dc6fb043ff58bd54e0c
    Signed-off-by: Dan Voiculeasa <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.3.0
Review: https://review.opendev.org/698300

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698300
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=dd838bf0c676e7db37886537ab3ca47e66e8f869
Submitter: Zuul
Branch: r/stx.3.0

commit dd838bf0c676e7db37886537ab3ca47e66e8f869
Author: Dan Voiculeasa <email address hidden>
Date: Fri Dec 6 18:28:51 2019 +0000

    Enable AIO Distributed Cloud patch vault

    Let /opt/patch-vault be mounted on AIO platform.

    Closes-Bug: 1853356
    Change-Id: If6e91cee5494c52f5da00dc6fb043ff58bd54e0c
    Signed-off-by: Dan Voiculeasa <email address hidden>
    (cherry picked from commit a8e6745ae238a3b44a750ddad289192c29898547)