Scope redfish optionality to node

[Brent Rowsell]

Currently redfish can only be disabled/enabled on a cluster basis through service parameters i.e.

system service-parameter-modify platform maintenance bmc_access_method=ipmi
system service-parameter-apply platform

This is too restrictive. The service parm needs to be removed and assignment done on a per-host basis using bm_type property with the following values:

    ipmi = use ipmi
    dynamic = use redfish if supported on the server else fall back to ipmi

The default if not specified would be dynamic.

[Ghada Khalil (gkhalil)]

stx.3.0 / medium - related to the redfish feature which is an stx.3.0 deliverable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697175

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697177

[Eric MacDonald (rocksolidmtce)]

This description needs to also include redfish only as a selectable option and how these options are set through horizon and the CLI. Here let me provide that info ...

Now, with this update and the current bmc_access_method as a service parameter removed, the system supports 3 Board Management provisioning options ; ipmi, redfish or dynamic along with (of course) the required BMC IP address, username and password (at the host level).

The bm_type is used to specify the method by which the system maintenance will communicate with the BMC to perform power/reset control as well as sensor monitoring. here is a summary of the selectable board management types.

bm_type=ipmi ... instructs system maintenance to use IPMI when communicating with the BMC
bm_type=redfish ... instructs system maintenance to use Redfish when communicating with the BMC
bm_type=dynamic ... allows system maintenance to choose the access method with a priority towards Redfish
                    if that host demonstrates Redfish support.
                    Otherwise system maintenance will default to use IPMI.

The current bm_type=bmc is now obsolete.

In the following are CLI Board Management provisioning options for each of the new bm_type access methods.

> system host-update <hostname> bm_type=ipmi bm_password=<bmc pw> bm_username=<bm un> bm_ip=<bm ip>
> system host-update <hostname> bm_type=redfish bm_password=<bmc pw> bm_username=<bm un> bm_ip=<bm ip>
> system host-update <hostname> bm_type=dynamic bm_password=<bmc pw> bm_username=<bm un> bm_ip=<bm ip>

In Horizon, like before, for the target host, select 'Edit Host' and the 'Board Management' tab which presents a pull down for 'Board Management Controller type' from which the administrator can select one of the the 3 provisioning options that correspond to the CLI type options mentioned above.

 - Dynamic (learn)
 - Redfish
 - IPMI

Select the preferred method followed by the BMC ip and credentials ; then select 'Save'.
System Inventory then sends this information to System Maintenance which then tries to establish connection to the target BMC using the specified board management type method.

If the information is valid and connection is established then that host's power and reset control become manageable by corresponding system commands and that hosts sensor model will be automatically learned, created and monitored.

If the BMC does not support the selected board management type (access method), say by having selected Redfish for a host that does not support redfish or an invalid bm ip or credentials, the Administrator will see a 'BMC access alarm' (200.010) warning after 2-3 minutes.

A host's BMC can be re-provisioned at any time. Any BMC provisioning changes trigger System Maintenance to re-establish / re-verify connection to the BMC. If the bm ip or board management controller type is changed then System Maintenance will also instruct the hardware monitor to relearn that hosts sensor model.

A host's BMC can be deprovisioned at any time with CLI by setting bm_type=none or selecting No Board Management Controller in the list of Board Management Controller types in Horizon > Edit Host > Board Management...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697175
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=fde58110015639f9ac9ab63ef04515a0cd3dac3f
Submitter: Zuul
Branch: master

commit fde58110015639f9ac9ab63ef04515a0cd3dac3f
Author: Bin Qian <email address hidden>
Date: Thu Nov 28 09:02:16 2019 -0500

    Add per-host board management protocol setting in sysinv

    Use bm_type field to store board management protocol setting,
    available bm protocols:
      redfish
      ipmi
      dynamic
      none (bm is not provisioned)

    The old service parameter bmc_access_method is removed.

    Partial-Bug: 1852328
    Change-Id: I5097e53f6fc1bfbe23d2a1b765b5bc0e25423c22
    Signed-off-by: Bin Qian <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697177
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=d3c094485070d03e7bbc9b3a46142eef99a22d0f
Submitter: Zuul
Branch: master

commit d3c094485070d03e7bbc9b3a46142eef99a22d0f
Author: Bin Qian <email address hidden>
Date: Fri Nov 29 10:17:31 2019 -0500

    Use new board management type enumuration

    Change horizon to list new board management type enumeration list below:
          redfish
          ipmi
          dynamic
          none (bm is not provisioned)

    Closes-Bug: 1852328
    Depends-On: https://review.opendev.org/697175
    Change-Id: If64eff8b0ee63509bdada6bba05847d292ce8032
    Signed-off-by: Bin Qian <email address hidden>

[Ghada Khalil (gkhalil)]

@Bin, please cherrypick to the r/stx.3.0 branch. Please complete this by Tuesday Dec 10.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.3.0
Review: https://review.opendev.org/698280

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.3.0
Review: https://review.opendev.org/698281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698281
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=24f8c503ac33ed7302a0e895b2541bac58b9caf1
Submitter: Zuul
Branch: r/stx.3.0

commit 24f8c503ac33ed7302a0e895b2541bac58b9caf1
Author: Bin Qian <email address hidden>
Date: Thu Nov 28 09:02:16 2019 -0500

    Add per-host board management protocol setting in sysinv

    Use bm_type field to store board management protocol setting,
    available bm protocols:
      redfish
      ipmi
      dynamic
      none (bm is not provisioned)

    The old service parameter bmc_access_method is removed.

    Partial-Bug: 1852328
    Change-Id: I5097e53f6fc1bfbe23d2a1b765b5bc0e25423c22
    Signed-off-by: Bin Qian <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698280
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=d1c22e49a95f92e91049b96f44e685f46785977c
Submitter: Zuul
Branch: r/stx.3.0

commit d1c22e49a95f92e91049b96f44e685f46785977c
Author: Bin Qian <email address hidden>
Date: Fri Nov 29 10:17:31 2019 -0500

    Use new board management type enumuration

    Change horizon to list new board management type enumeration list below:
          redfish
          ipmi
          dynamic
          none (bm is not provisioned)

    Closes-Bug: 1852328
    Depends-On: https://review.opendev.org/#/c/698281
    Change-Id: If64eff8b0ee63509bdada6bba05847d292ce8032
    Signed-off-by: Bin Qian <email address hidden>