no alarms if ptp on controller can't lock to remote grand master

[Gerry Kopec]

Brief Description
-----------------
On AIO-SX, enabled clock_synchronization to ptp, lock/unlocked controller. As there was no grand master set up in system, would expect there to be a host "is not locked to remote PTP Grand Master" alarm but there were no alarms.

Severity
--------
Minor

Steps to Reproduce
------------------
Set host clock_synchronization to ptp, lock/unlocked controller.

Expected Behavior
------------------
Should see host "is not locked to remote PTP Grand Master" alarm

Actual Behavior
----------------
No alarms seen

Reproducibility
---------------
Reproducible

System Configuration
--------------------
One node system

Branch/Pull Time/Commit
-----------------------
2019-09-23_20-00-00

Last Pass
---------
n/a

Timestamp/Logs
--------------
2019-10-29T12:46:07.000 controller-0 ptp4l: info [297.135] selected /dev/ptp3 as PTP clock
2019-10-29T12:46:07.000 controller-0 ptp4l: warning [297.156] driver changed our HWTSTAMP options
2019-10-29T12:46:07.000 controller-0 ptp4l: warning [297.156] tx_type 1 not 1
2019-10-29T12:46:07.000 controller-0 ptp4l: warning [297.156] rx_filter 1 not 12
2019-10-29T12:46:07.000 controller-0 ptp4l: notice [297.156] port 1: INITIALIZING to LISTENING on INIT_COMPLETE
2019-10-29T12:46:07.000 controller-0 ptp4l: notice [297.156] port 0: INITIALIZING to LISTENING on INIT_COMPLETE
2019-10-29T12:46:15.000 controller-0 ptp4l: warning [304.679] driver changed our HWTSTAMP options
2019-10-29T12:46:15.000 controller-0 ptp4l: warning [304.679] tx_type 1 not 1
2019-10-29T12:46:15.000 controller-0 ptp4l: warning [304.679] rx_filter 1 not 12
2019-10-29T12:46:15.000 controller-0 ptp4l: notice [304.679] selected best master clock 1402ec.fffe.493f7d

sudo pmc -u -b 0 "GET TIME_STATUS_NP"
sending: GET TIME_STATUS_NP
        1402ec.fffe.493f7d-0 seq 0 RESPONSE MANAGEMENT TIME_STATUS_NP
                master_offset 0
                ingress_time 0
                cumulativeScaledRateOffset +0.000000000
                scaledLastGmPhaseChange 0
                gmTimeBaseIndicator 0
                lastGmPhaseChange 0x0000'0000000000000000.0000
                gmPresent false
                gmIdentity 1402ec.fffe.493f7d
[sysadmin@controller-0 ~(keystone_admin)]$ sudo pmc -u -b 0 "GET PORT_DATA_SET"
sending: GET PORT_DATA_SET
        1402ec.fffe.493f7d-1 seq 0 RESPONSE MANAGEMENT PORT_DATA_SET
                portIdentity 1402ec.fffe.493f7d-1
                portState LISTENING
                logMinDelayReqInterval 0
                peerMeanPathDelay 0
                logAnnounceInterval 1
                announceReceiptTimeout 3
                logSyncInterval 0
                delayMechanism 1
                logMinPdelayReqInterval 0
                versionNumber 2

[sysadmin@controller-0 ~(keystone_admin)]$ sudo pmc -u -b 0 "GET SLAVE_ONLY"
Password:
sending: GET SLAVE_ONLY
        1402ec.fffe.493f7d-0 seq 0 RESPONSE MANAGEMENT SLAVE_ONLY
                slaveOnly 1

Test Activity
-------------

[Eric MacDonald (rocksolidmtce)]

Update implemented.
Build in progress.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/691988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691988
Committed: https://git.openstack.org/cgit/starlingx/monitoring/commit/?id=d12b1a9e703e51b55aa788951d408c0b8a654a17
Submitter: Zuul
Branch: master

commit d12b1a9e703e51b55aa788951d408c0b8a654a17
Author: Eric MacDonald <email address hidden>
Date: Tue Oct 29 17:17:29 2019 -0400

    Add ptp no-lock alarm support for controllers

    The current PTP No-Lock alarm is not raised for
    controllers that assume Grandmastership.

    This is incorrect behavior. Every node configured
    for PTP needs to be locked to a remote Grandmaster.

    This update increases the scope of the no lock alarm
    to apply to all node types ; computes, storage and
    now controllers as well.

    Test Plan:

    PASS: Verify PTP no lock alarm for controller.

    Change-Id: I271c8ad235e6cb680bdb27f377149b7e1a3d14cd
    Closes-Bug: 1850554
    Signed-off-by: Eric MacDonald <email address hidden>