Patch Orchestration may not detect openstack alarms

Bug #1850441 reported by Al Bailey on 2019-10-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Medium
Dariush Eslimi

Bug Description

This is a "future" bug for when containerized openstack alarms are enabled.
It is not a bug at the moment, but it will be once the feature is enabled.

In the file:
https://opendev.org/starlingx/nfv/src/branch/master/nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py

in the apply method for the QueryAlarmsStep class the code currently looks like:

        self.strategy.nfvi_alarms = list()
        nfvi.nfvi_get_alarms(self._query_alarms_callback("platform"))
        if not nfvi.nfvi_fault_mgmt_plugin_disabled():
            nfvi.nfvi_get_openstack_alarms(self._query_alarms_callback("openstack"))
        return strategy.STRATEGY_STEP_RESULT.WAIT, ""

At the moment the fault_mgmt_plugin is disabled, but it will soon be enabled.

The problem with this code is that the "platform" alarms will trigger the callback and so will the "openstack" alarms. This would cause this step to move on when either is queried, rather than both.

This code needs to be revisited. Possibly by splitting this class into 2 different steps, or by re-examining the callback handling code.

Ghada Khalil (gkhalil) wrote :

Marking for stx.4.0 given fault containerization will only be enabled for that release.
Assigning to flock PL for follow-up

tags: added: stx.4.0 stx.fault stx.update
Changed in starlingx:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Dariush Eslimi (deslimi)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers