Patch Orchestration may not detect openstack alarms

[Al Bailey]

This is a "future" bug for when containerized openstack alarms are enabled.
It is not a bug at the moment, but it will be once the feature is enabled.

In the file:
https://opendev.org/starlingx/nfv/src/branch/master/nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py

in the apply method for the QueryAlarmsStep class the code currently looks like:

        self.strategy.nfvi_alarms = list()
        nfvi.nfvi_get_alarms(self._query_alarms_callback("platform"))
        if not nfvi.nfvi_fault_mgmt_plugin_disabled():
            nfvi.nfvi_get_openstack_alarms(self._query_alarms_callback("openstack"))
        return strategy.STRATEGY_STEP_RESULT.WAIT, ""

At the moment the fault_mgmt_plugin is disabled, but it will soon be enabled.

The problem with this code is that the "platform" alarms will trigger the callback and so will the "openstack" alarms. This would cause this step to move on when either is queried, rather than both.

This code needs to be revisited. Possibly by splitting this class into 2 different steps, or by re-examining the callback handling code.

[Ghada Khalil (gkhalil)]

Marking for stx.4.0 given fault containerization will only be enabled for that release.
Assigning to flock PL for follow-up

[Ghada Khalil (gkhalil)]

Lowering the priority - As noted in the description, this will only become an issue with fault containerization is enabled. This has not happened for stx.4.0 and is not likely given how close we are to MS-3.