Distributed Cloud: Uploading patches to System Controller does not seem to work

[Yosief Gebremariam]

Brief Description
-----------------
Uploading patches to System Controller in DC system, installed with 2019-10-22_20-00-00 build, is not working using both CLI and Horizon. The command "sw-patch --os-region-name SystemController upload 2019-10-22_20-00-00_INSVC_CONTROLLER.patch" returned with no upload action or error message:

[sysadmin@controller-0 patches(keystone_admin)]$ sw-patch --os-region-name SystemController upload 2019-10-22_20-00-00_INSVC_CONTROLLER.patch
[sysadmin@controller-0 patches(keystone_admin)]$ echo $?
1

The above command simply exists without any meaningful log.

Querying System Controller for patches seems ok:
[sysadmin@controller-0 patches(keystone_admin)]$ sw-patch --os-region-name SystemController query
Patch ID RR Release Patch State
======== == ======= ===========

Upload to RegionOne still works fine.
[sysadmin@controller-0 patches(keystone_admin)]$ sudo sw-patch upload 2019-10-22_20-00-00_INSVC_CONTROLLER.patch
2019-10-22_20-00-00_INSVC_CONTROLLER is now available
[sysadmin@controller-0 patches(keystone_admin)]$ sudo sw-patch delete 2019-10-22_20-00-00_INSVC_CONTROLLER
2019-10-22_20-00-00_INSVC_CONTROLLER has been deleted

Severity
--------
Major

Steps to Reproduce
------------------
Attempt to upload a patch to the System Controller region.

TC-name: DC system Patching

Expected Behavior
------------------
The patch is uploaded to the System Controller region.

Actual Behavior
----------------
The command exited without uploading the patch

Reproducibility
---------------
100%.

System Configuration
--------------------

Lab-name: DC System with 4 subclouds

Branch/Pull Time/Commit
-----------------------
"2019-10-22_20-00-00"

Last Pass
---------
"2019-10-20_20-00-00"
Using CLI upload in service patches passed

Timestamp/Logs
Collected logs are attached.

Test Activity
-------------
Regression

[Ghada Khalil (gkhalil)]

stx.3.0 / high priority - prevents patching on distributed cloud. Issue was introduced by recent changes: https://review.opendev.org/#/c/689538

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/691447

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691447
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=c0e54ee4deff6d9ffa8686bcb305d99c3eeb22dd
Submitter: Zuul
Branch: master

commit c0e54ee4deff6d9ffa8686bcb305d99c3eeb22dd
Author: Tyler Smith <email address hidden>
Date: Fri Oct 25 17:45:02 2019 -0400

    Request forwarding and version matching in dcorch proxy

    Need to pass in the application to be the forwarder so when
    the version doesn't match the request can continue down the
    pipeline. It was 'mostly' working before since the version
    matching was registering all get requests as version requests
    and just forwarding them, this commit also restricts that
    version regex so that is no longer the case.

    Change-Id: I887027a043e2a686770d4ece0ae511e00814be61
    Closes-Bug: 1849831
    Signed-off-by: Tyler Smith <email address hidden>

[Yang Liu (yliu12)]

Peng has retested it on 1105 load and passed.