AIO-SX: disk needs to be wiped before new install if the disk was previously OSD

[Peng Peng]

Brief Description
-----------------
AIO-SX, install from USB. Installation failed at unable to allocate registed partition scheme. It seems /dev/sda was not wiped before installation start and this disk was used as Ceph OSD from previous load.

Severity
--------
Major

Steps to Reproduce
------------------
as description

TC-name: DC system AIO SX subcloud installation

Expected Behavior
------------------

Actual Behavior
----------------

Reproducibility
---------------
Reproducible

System Configuration
--------------------
One node system

Lab-name: WCP_89

Branch/Pull Time/Commit
-----------------------
"2019-10-06_20-00-00"

Last Pass
---------

Timestamp/Logs
--------------
Starting installer, one moment... 4:storage-log 5:program-log
anaconda 21.48.22.147-1 for CentOS 7 started.
al 4962.54 MiB is needed.l 3:log 4:storage-log 5:> Switch: Alt+Tab or Ctrl-o
 * installation log files are stored in /tmp during the installation
 * shell is available on TTY2

[anaconda root@localhost ~]# cat /proc/cmdline
rootwait console=ttyS0,115200 inst.text serial inst.stage2=hd:LABEL=oe_iso_boot
inst.ks=hd:LABEL=oe_iso_boot:/smallsystem_ks.cfg boot_device=sda rootfs_device=
da biosdevname=0 usbcore.autosuspend=-1 inst.gpt security_profile=standard user
namespace.enable=1 initrd=initrd.img BOOT_IMAGE=vmlinuz

[anaconda root@localhost ~]# ls -l /dev/disk/by-path
total 0
lrwxrwxrwx. 1 root root 9 Oct 15 18:58 pci-0000:00:14.0-usb-0:7:1.0-scsi-0:0:0
0 -> ../../sdc
lrwxrwxrwx. 1 root root 10 Oct 15 18:58 pci-0000:00:14.0-usb-0:7:1.0-scsi-0:0:0
0-part1 -> ../../sdc1
lrwxrwxrwx. 1 root root 10 Oct 15 18:58 pci-0000:00:14.0-usb-0:7:1.0-scsi-0:0:0
0-part2 -> ../../sdc2
lrwxrwxrwx. 1 root root 9 Oct 15 18:59 pci-0000:00:1f.2-ata-1.0 -> ../../sda
lrwxrwxrwx. 1 root root 10 Oct 15 18:59 pci-0000:00:1f.2-ata-1.0-part1 -> ../..
sda1
lrwxrwxrwx. 1 root root 10 Oct 15 18:59 pci-0000:00:1f.2-ata-1.0-part2 -> ../..
sda2
lrwxrwxrwx. 1 root root 9 Oct 15 18:58 pci-0000:00:1f.2-ata-2.0 -> ../../sdb

[anaconda root@localhost ~]# fdisk -l /dev/sda
WARNING: fdisk GPT support is currently new, and therefore in an experimental p
ase. Use at your own discretion.

Disk /dev/sda: 480.1 GB, 480103981056 bytes, 937703088 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes
Disk label type: gpt
Disk identifier: F1308F54-C9A3-4155-8E10-631470477A1A

# Start End Size Type Name
 1 2099200 937703054 446.1G Ceph OSD ceph data
 2 2048 2099199 1G Ceph Journal ceph journal
[anaconda root@localhost ~]# vi /tmp/storage.log

Test Activity
-------------
AIO-SX installation

[Ghada Khalil (gkhalil)]

Low / not gating - this is not a typical scenario.

[Ovidiu Poncea (ovidiuponcea)]

This is expected behavior at installation, we avoid wiping OSDs as at his stage we don't know what is user intention
(i.e. this may be part of the B&R procedure and data must be protected). Even if OSDs are configured as rootdisks, we don’t know what is the user intention and, if autoinstaller wipes a wrong disk by mistake then data loss is irreversible (it's easy to mistakenly install on the wrong disk, especially if PXE is used). Therefore, this is a protection measure we take to avoid data loss.

Two paths are possible here:
1. We close the issue as invalid
2. We print a meaningful message showing what's happening
3. We prompt the user during installation to confirm the OSD disk wipe.