aio-dx duplex-direct ifup failure because of interface name mismatch

[Allain Legacy]

Brief Description
-----------------
The initial controller unlock on an AIO-DX duplex-direct system fails because of a failure to bring up the mgmt interface. The issue appears related to how the interface name is constructed for the ifcfg script's pre-up option. The name used is the configured interface name rather than the o/s interface name.

This error occurs when the ifup is attempted manually:

controller-0:/var/log/puppet# sudo ifup enp135s0f0
sysctl: cannot stat /proc/sys/net/ipv6/conf/mgmt0/accept_dad: No such file or directory

This is related to the fix for bug: https://bugs.launchpad.net/starlingx/+bug/1834234

Severity
--------
Critical, the first unlock fails and the system is not recoverable.

Steps to Reproduce
------------------
Install an AIO-DX duplex-direct system with mgmt network on a physical interface and cluster-host on a vlan interface.

Expected Behavior
------------------
The unlock should succeed and the initial reboot should successfully enable all platform services.

Actual Behavior
----------------
The unlock succeeds, but platform services are not enabled due to the missing mgmt IP address related to the interface configuration failure.

Reproducibility
---------------
100%

System Configuration
--------------------
AIO-DX duplex-direct

Branch/Pull Time/Commit
-----------------------
09/oct/2019

Last Pass
---------
07/oct/2019

Timestamp/Logs
--------------
See above

Test Activity
-------------
Feature testing

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / high priority - issue is introduced by recent code changes and makes a supported config (AIO-Duplex-Direct w/ IPv4) not usable.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687973

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687973
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=5391bbca233dd344552c83757c5e0716c34e52e4
Submitter: Zuul
Branch: master

commit 5391bbca233dd344552c83757c5e0716c34e52e4
Author: Teresa Ho <email address hidden>
Date: Thu Oct 10 14:58:04 2019 -0400

    Fix interface name for sysctl cmd in ifcfg file

    The configured interface name was used in setting a pre-up option
    in the ifcfg file. This commit is to correct it by using the o/s
    interface name.

    Closes-Bug: 1847625

    Change-Id: I9f6cea67b49f4e16ae95725002099fba644485a9
    Signed-off-by: Teresa Ho <email address hidden>