Backup & Restore: wipe_ceph_osds should not be mandatory

[Senthil Mukundakumar]

Brief Description
-----------------

For wipe_ceph_osd the default value is set to false when we don't specify in CLI. But the restore operation fails with the following error if wipe_ceph_osd is not specified in CLI.

TASK [restore-platform/prepare-env : Check for Ceph data wipe flag] *************************************
fatal: [sm5]: FAILED! => {"msg": "The conditional check '(not wipe_ceph_osds | type_debug == 'bool') and (wipe_ceph_osds != 'true') and (wipe_ceph_osds != 'false')' failed. The error was: error while evaluating conditional ((not wipe_ceph_osds | type_debug == 'bool') and (wipe_ceph_osds != 'true') and (wipe_ceph_osds != 'false')): 'wipe_ceph_osds' is undefined\n\nThe error appears to be in '/localdisk/designer/smukunda/starlingx-0/cgcs-root/stx/ansible-playbooks/playbookconfig/src/playbooks/roles/restore-platform/prepare-env/tasks/main.yml': line 34, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n # See: https://github.com/ansible/ansible/issues/17193\n - name: Check for Ceph data wipe flag\n ^ here\n"}

PLAY RECAP **********************************************************************************************
sm5 : ok=6 changed=2 unreachable=0 failed=1 skipped=6 rescued=0 ignored=0

Severity
--------

Minor - User can still proceed with install by specifying in CLI

Steps to Reproduce
------------------
1. Create an environment for ansible remote host
2. Bring up the AIO-DX system
3. Backup the system using ansible remotely
4. Re-install the controller with the same load
5. Restore the system using ansible remotely.

Expected Behavior
------------------
The active controller is successfully restored without wipe_ceph_osds parameter in CLI

Actual Behavior
----------------
Active controller failed to restore, expecting the parameter wipe_ceph_osds as mandate

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any IPV4 system

Branch/Pull Time/Commit
-----------------------
 BUILD_ID="2019-10-07_20-00-00"

Test Activity
-------------
Feature Testing

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / medium priority - related to B&R which is an stx.3.0 feature deliverable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689529

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689529
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=4964dd1e1ab96b9180499ff0a7a027dfe25f1176
Submitter: Zuul
Branch: master

commit 4964dd1e1ab96b9180499ff0a7a027dfe25f1176
Author: Dan Voiculeasa <email address hidden>
Date: Fri Oct 18 13:40:37 2019 +0000

    B&R fix Ansible undefined variable

    Ansible fails when variables are not defined.
    wipe_ceph_osds was not defined when running restore.

    Closes-Bug: 1847620
    Change-Id: I15164e218e96a2eff6177e525d059095e645f981
    Signed-off-by: Dan Voiculeasa <email address hidden>

[Senthil Mukundakumar (smukunda)]

Verified using load 2019-10-28_09-12-55