if hugepage is not config, can not unlock host

[Austin Sun]

Brief Description
-----------------
if hugepage is not config in worker node, this worker node can not be unlocked

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
1) adding worker node w/o hugepage configed,
2) unlock this worker node
Expected Behavior
------------------
Write down what was expected after taking the steps written above
This kind of node can be unlocked successfully

Actual Behavior
----------------
State what is the actual behavior
raise Exception
  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 1774, in patch
    return self._patch_gen(uuid, patch, profile_uuid)

  File "/usr/lib/python2.7/site-packages/oslo_concurrency/lockutils.py", line 274, in inner
    return f(*args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 1782, in _patch_gen
    return self._patch(uuid, patch, profile_uuid)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 1912, in _patch
    if self.action_check(myaction, hostupdate):

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 4250, in action_check
    self.check_unlock(hostupdate, force_unlock)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 4961, in check_unlock
    self.check_unlock_worker(hostupdate, force_unlock)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 5267, in check_unlock_worker
    self._semantic_check_memory_for_node(ihost, node)

  File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/host.py", line 3443, in _semantic_check_memory_for_node
    allocated += m.vswitch_hugepages_nr * m.vswitch_hugepages_size_mib

TypeError: unsupported operand type(s) for *: 'NoneType' and 'NoneType'

Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
100%

System Configuration
--------------------
multi-node
Branch/Pull Time/Commit
-----------------------
lastest

Last Pass
---------
NA
Timestamp/Logs
--------------

Test Activity
-------------
Evaluation

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.2.0
Review: https://review.opendev.org/687810

[OpenStack Infra (hudson-openstack)]

Change abandoned by Austin Sun (<email address hidden>) on branch: r/stx.2.0
Review: https://review.opendev.org/687810
Reason: wrong branch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687811

[Ghada Khalil (gkhalil)]

@Tao Liu, Isn't this intentional based on recent huge page re-work?

[Tao Liu (tliu88)]

If the vswitch type is set to none, unlock should work without provisioning of huge pages.

[Ghada Khalil (gkhalil)]

@Austin, Can you clarify the scenario you are reporting? What was the vswitch type set to?

[Austin Sun (sunausti)]

Hi, Ghada:
    I'm doing some exploration on some other linux type worker node, and /etc/platform/worker_reserved.conf was not config.
    Thanks.

[Ghada Khalil (gkhalil)]

Changing the priority to Low given none of the supported configurations are currently broken. This appears to be a future-proofing exercise.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687811
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=c0e09524c9f5274091411db99d2b8484461248f7
Submitter: Zuul
Branch: master

commit c0e09524c9f5274091411db99d2b8484461248f7
Author: Sun Austin <email address hidden>
Date: Thu Oct 10 15:29:57 2019 +0800

    if hugepage is not configed in worker node, node can not be unlocked.

    The hugepages_configured attribute of the Memory class is a string,
    so change the condition to compare with string

    Change-Id: Ic74d713fef04a4a8d464e51d95f4b526eddf7c64
    Closes-bug: 1847572
    Signed-off-by: Sun Austin <email address hidden>