stx-puppet commits blocked by puppet-lint warnings

[Al Bailey]

It looks as though puppet-lint 2.4.0 and 2.4.1 were just released but these cause zuul to fail.

This blocking submissions to stx-puppet by zuul.

Fix is on its way.

[Al Bailey (albailey1974)]

https://review.opendev.org/#/c/687671/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687671
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=590ae77b351cd1456bbc7405259f16a0f3e63fe3
Submitter: Zuul
Branch: master

commit 590ae77b351cd1456bbc7405259f16a0f3e63fe3
Author: Al Bailey <email address hidden>
Date: Wed Oct 9 15:21:28 2019 -0500

    Fix puppet-lint errors

    Running tox locally or through zuul would fail with
    puppet-lint warnings.

    This was introduced by puppet-lint 2.4.0 and still exists
    in 2.4.1

    2.3.6 works as expected, so now we are clamping
    to that version.

    Change-Id: I19a1d4df2b299e4dcb581df43874d8e1866b3962
    Closes-Bug: 1847534
    Signed-off-by: Al Bailey <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / high priority - this blocks further submissions to stx-puppet due to zuul failures