Maintenance fails VIM systems query audit

[Eric MacDonald]

Brief Description
-----------------
The mtcAgent is incorrectly reporting a systems query parse error.

Severity
--------
Minor: Does not seem to have an impact on the VIM or mtce aside from the periodic error logging shortly after the install. The audit seems to stop after 10 minutes.

Steps to Reproduce
------------------
fresh system install

Expected Behavior
------------------
VIM systems query audit succeeds.

Actual Behavior
----------------
VIM systems query audit fails.

Reproducibility
---------------
Intermittent

System Configuration
--------------------
AIO-dx, possibly others.

Branch/Pull Time/Commit
-----------------------
2d4fcd11693fd1708c1cf2cf8788892db7611359 added a hostname check too early in mtcHttpSvr_handler procedure which caused the error.

Last Pass
---------
Unknown

Timestamp/Logs
--------------

mtcAgent.log
------------
2019-10-08T18:37:04.542 [122250.00143] controller-0 mtcAgent svr mtcHttpSvr.cpp ( 847) mtcHttpSvr_handler : Warn : uuid to host lookup failed ; 's' not found
2019-10-08T18:37:04.542 [122250.00144] controller-0 mtcAgent svr mtcHttpSvr.cpp ( 993) mtcHttpSvr_handler : Warn : sending 404 response for GET:/v1/systems request ; response:{ "status" : "fail","reason" : "not found","action" : "retry with valid host"}

mtcAgent_event.log
------------------
2019-10-08T18:37:04.542 [122250] http event seq: 4 with vim GET request from localhost:/v1/systems
2019-10-08T18:37:04.542 [122250] http event seq: 4 Response:: { "status" : "fail","reason" : "not found","action" : "retry with valid host"}

Test Activity
-------------
Developer Testing

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687561

[Ghada Khalil (gkhalil)]

Low priority - no system impact

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687561
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=9ddbf7bf6f38b8d88a6e4e73963dd650d08f5627
Submitter: Zuul
Branch: master

commit 9ddbf7bf6f38b8d88a6e4e73963dd650d08f5627
Author: Eric MacDonald <email address hidden>
Date: Wed Oct 9 09:12:41 2019 -0400

    Fix Mtce's VIM systems query handling

    A bug was recently introduced by improperly trying to fix
    the handling of an invalid host lookup error in the mtce
    http server handler.

    The impact of this issue is to prolong the VIM DOR mode
    to the point of its timeout.

    This update makes the necessary changes to remove the new
    issue and properly handle the original issue.

    This update also improves client code handling and ensures the
    service url length is loaded correctly based on client making
    the request.

    Test Plan:

    PASS: Verify AIO DX System Install
    PASS: Verify maintenance logs for evidence of corrected behavior

    Change-Id: I0fe09b5a17f5fc1a6dd84876cef575dd15c88db2
    Closes-Bug: 1847334
    Signed-off-by: Eric MacDonald <email address hidden>