CREATEREPO not defined in generate-cgcs-tis-repo

[Saul Wold]

If the cgcs-tis-repo/Source directory contains a repodata, the script tries to call $CREATEREPO as a variable. This variable is not set by default and needs to be initialized.

Solution is to add check to assign CREATEREPO a valid value

Use this code snippet:

CREATEREPO=$(which createrepo_c)
if [ $? -ne 0 ]; then
   CREATEREPO="createrepo"
fi

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/686291

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / medium priority given this results in a tool failure

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/686291
Committed: https://git.openstack.org/cgit/starlingx/tools/commit/?id=c6bdb70f242fa39d5f692d15720d44b11518aec9
Submitter: Zuul
Branch: master

commit c6bdb70f242fa39d5f692d15720d44b11518aec9
Author: Saul Wold <email address hidden>
Date: Wed Oct 2 13:38:15 2019 -0700

    Add definiton of $CREATEREPO

    The CREATEREPO variable was not getting set causing the script
    to fail, additionally, use the variable consistently instead
    of calling createrepo directly.

    Closes-Bug: 1846387
    Change-Id: If42d5ca14aa9d7ace1d0d6d9daf846a9e51ab559
    Signed-off-by: Saul Wold <email address hidden>