AIO-DX + worker: Editing host fields using horizon is failing

[Anujeyan Manokeran]

Brief Description
-----------------
    Editing host fileds such as clock_synchronization from NTP to PTP or location was failing on AIO-DX + worker system using horizon gui. But this was working fine using cli as system host-update compute-0 clock_synchronization=ptp.
Attached horizon gui image have below error message.

Error: Unable to modify host "compute-0". The following fields can not be modified because this host compute-0 has been configured: hostname, personality, subfunctions

Severity
--------
Major

Steps to Reproduce
------------------
1.Verify AIO+DX worker good health
2. Logging in to horizon
3. Edit worker hosts clock_synchronization=PTP fails as per description. Also fails for other fields such as location.

System Configuration
--------------------
AIO+worker system with IPv6 configuration wolfpass8-13
Expected Behavior
------------------
Able modify hosts clock_synchronization=PTP using horizon .

Actual Behavior
----------------
As per description it was not modified
Reproducibility
---------------
100% reproduce able.
Load
----
Build was on "2019-10-01_20-00-00"
Last Pass
---------
Timestamp/Logs
--------------
2019-10-02T15:50:27.000

Test Activity
-------------
Regression test

[Anujeyan Manokeran (anujeyan)]

Actually when I did further test on horizon edit host on AIO+DX +worker I noticed above error is seen when modifying other fields as well. Eg: location .

[Ghada Khalil (gkhalil)]

stx.3.0 / medium priority - horizon not working for setting a number of attributes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687612

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687612
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=b82c7a5cd363513b6a3028b8c34454f87c17aa68
Submitter: Zuul
Branch: master

commit b82c7a5cd363513b6a3028b8c34454f87c17aa68
Author: Bin Qian <email address hidden>
Date: Wed Oct 9 12:16:50 2019 -0400

    A disabled field is not readonly

    Hostname, personality, subfunction fields shall be readonly, not
    disabled, if such filed has been set. A disabled field only prevents
    end user from editing it directly from GUI, the server side code
    still condisder it "writable"

    Change-Id: I64d63476ecbfc391a4f6194e6b972b4800a82c13
    Close-Bug: 1846363
    Signed-off-by: Bin Qian <email address hidden>

[Anujeyan Manokeran (anujeyan)]

Verified in load 2019-10-25_20-00-00.