User is unable to save default host configuration from GUI when adding a new host

Bug #1846362 reported by Stephen Gooch
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Bin Qian

Bug Description

The default boot_device and rootfs_device values for a new unconfigured host were updated from sda to /dev/sda in a recent update:
https://opendev.org/starlingx/config/blame/branch/master/sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py#L228
https://review.opendev.org/#/c/669726/10/sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py

However, the starlingx-dashboard uses a form validation for these values that rejects absolute paths other than /dev/disk/by-path. As a result, the default value of /dev/sda gets rejected and cannot be saved from the GUI:
https://opendev.org/starlingx/gui/src/branch/master/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/workflows.py#L521
https://opendev.org/starlingx/gui/src/branch/master/starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/dashboards/admin/inventory/workflows.py#L529

Revision history for this message
Ghada Khalil (gkhalil) wrote :

stx.3.0 gating - GUI needs to be aligned to recent sysinv changes related to device names

tags: added: stx.gui
tags: added: stx.3.0
Changed in starlingx:
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → Kristine Bujold (kbujold)
Changed in starlingx:
assignee: Kristine Bujold (kbujold) → David Sullivan (dsullivanwr)
Bin Qian (bqian20)
Changed in starlingx:
assignee: David Sullivan (dsullivanwr) → Bin Qian (bqian20)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/687871

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/687871
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=241a01403496bf1a00bda1d2e991b9ac2f933e3f
Submitter: Zuul
Branch: master

commit 241a01403496bf1a00bda1d2e991b9ac2f933e3f
Author: Bin Qian <email address hidden>
Date: Thu Oct 10 08:17:58 2019 -0400

    Remove incorrect regex validator for rootfs and boot_device

    The regex restriction for the fields boot_device and rootfs_device are
    conflict against the default setting of both fields. The settings with
    absolute path ('/dev/disk/') work no problem.

    Change-Id: Ie8f8c4935bd5c1846f2d62c23d65b261e324cc5a
    Closes-Bug: 1846362
    Signed-off-by: Bin Qian <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.