Distributed Cloud: Horizon on Central Cloud can not switch to SystemController Region or subcloud Region

[Greg Waines]

Brief Description
-----------------
A number of problems exist with Distributed Cloud Horizon at Central Cloud:

1. Switching to SystemController region in Horizon is failing ... authentication error

2. Switching to Subcloud Regions is also not working in Horizon.

3. System info page in systemcontroller is broken

4. Nav menu in systemcontroller is broken. This is due to a new upstream panel added to identity dashboard ‘application credentials’, it does a check for identity api version, which apparently isn’t handled well by systemcontroller region and we get a keystone error

  File "/usr/lib/python2.7/site-packages/keystoneauth1/discover.py", line 1240, in _run_discovery
    "Version requested but version discovery document was not"

Severity
--------
<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------
Switch to either SystemController region or subcloud region in horizon running on Central Cloud of Distributed Cloud solution.

Expected Behavior
------------------
Switch to Horizon pages for selected region.

Actual Behavior
----------------
Authentication error

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Any Distributed Cloud configuration.

Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------
Never passed.

Timestamp/Logs
--------------
NA

Test Activity
-------------
[Evaluation]

[Ghada Khalil (gkhalil)]

stx.3.0 / high priority - issue with Distributed Cloud which is an stx.3.0 feature deliverable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/686445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/686445
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=a67f2ea241d6631da6d776c3bbe2f1b12feab8e7
Submitter: Zuul
Branch: master

commit a67f2ea241d6631da6d776c3bbe2f1b12feab8e7
Author: Tyler Smith <email address hidden>
Date: Thu Oct 3 13:14:30 2019 -0400

    Distributed Cloud fix for switching between RegionOne and SystemController

    Adds custom home lookup function and JS to automatically redirect
    when authorization errors are hit to make the transition more seamless

    Change-Id: I9dfda59ce216db4d562094b309ac7809c7a80735
    Partial-Bug: 1846239
    Signed-off-by: Tyler Smith <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687935

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/687955

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687955
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=307e13dd223fe96ac84e0f1a8b9767227237596e
Submitter: Zuul
Branch: master

commit 307e13dd223fe96ac84e0f1a8b9767227237596e
Author: Tyler Smith <email address hidden>
Date: Thu Oct 10 11:45:03 2019 -0400

    Adding permissions to controller services tab

    This was causing issues in SystemCotnroller region as
    smapi is not configured in that region

    Change-Id: I5775b9d913096af4f1873740f143e520783a9f1d
    Partial-Bug: 1846239
    Signed-off-by: Tyler Smith <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689259

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689538

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689259
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=a13e9751c744a8633d1355712f7973ad92311ca6
Submitter: Zuul
Branch: master

commit a13e9751c744a8633d1355712f7973ad92311ca6
Author: Tyler Smith <email address hidden>
Date: Thu Oct 17 16:24:55 2019 -0400

    Improvements to horizon for distributed cloud

    - removing the generate config button as it is no longer used
    - removing the add subcloud form as it cannot easily be made to
      work with the file-based subcloud addition we use now
    - Update to inventory link

    Change-Id: I17b6e0c485fc6233b6e35d9e18f05cb2d55e113e
    Partial-Bug: 1846239
    Signed-off-by: Tyler Smith <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689538
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=96db1d7ee018a847bb9c5360036d3e8081db159f
Submitter: Zuul
Branch: master

commit 96db1d7ee018a847bb9c5360036d3e8081db159f
Author: Tyler Smith <email address hidden>
Date: Fri Oct 18 12:18:53 2019 -0400

    Distributed Cloud enhancements for Horizon

    - Adding endpoints for the subcloud's platform services to the central
      keystone. This was done so horizon can reach all subclouds
    - Allowing version requests to bypass the authtoken validator in the
      dcorch proxy. version requests do not require authentication and
      they are required by horizon to work in the SystemController region

    Change-Id: I508e0168e77d1f46b8f5720fd16047177b4920c2
    Partial-Bug: 1846239
    Signed-off-by: Tyler Smith <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/687935
Committed: https://git.openstack.org/cgit/starlingx/stx-puppet/commit/?id=84ab354b54bf5612fcf86bee665cc9589dec19db
Submitter: Zuul
Branch: master

commit 84ab354b54bf5612fcf86bee665cc9589dec19db
Author: Tyler Smith <email address hidden>
Date: Thu Oct 10 11:20:06 2019 -0400

    Adding version acceptor to dcorch proxy

    authtoken validation was causing issues with horizon doing identity
    api version lookups while checking permissions for the application
    credentials panel when in the SystemController region. This adds
    an acceptor to bypass the authtoken checks for the identity root
    address (/v3)

    Change-Id: I43bd1b107b74713740238c225c756f88aa42a237
    Depends-On: https://review.opendev.org/#/c/689538
    Closes-Bug: 1846239
    Signed-off-by: Tyler Smith <email address hidden>