Code cleanup related to license handling

Bug #1845522 reported by Ghada Khalil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Bin Qian

Bug Description

Brief Description
-----------------
There is code in starlingx related to license handling that is failing. This code was left-over from the original code base since the beginning of the project. This code should be cleaned up to handle the lack of licenses gracefully.

Severity
--------
Minor - code cleanup

Steps to Reproduce
------------------
Run system license-install

Expected Behavior
------------------
Command fails with a missing library

Actual Behavior
----------------
Command should do nothing given there are no license requirements for starlingx

Reproducibility
---------------
Reproudcible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master since day 1

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Other - code review

Revision history for this message
Ghada Khalil (gkhalil) wrote :

Minor as this is related to code cleanup

Changed in starlingx:
importance: Undecided → Low
assignee: nobody → Bin Qian (bqian20)
tags: added: stx.config stx.ha
Changed in starlingx:
status: New → Triaged
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to utilities (master)

Fix proposed to branch: master
Review: https://review.opendev.org/685397

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/685394
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=54f164a193708d603d6f3dfe5a4ceff62a8eac9c
Submitter: Zuul
Branch: master

commit 54f164a193708d603d6f3dfe5a4ceff62a8eac9c
Author: Bin Qian <email address hidden>
Date: Fri Sep 27 12:06:30 2019 -0400

    Clean up licensing code

    Remove "system license-list" command,
    replace with "system license-show"
    The new system license-show command shows the content of the
    license file

    Remove any validation and interpretation of license file.

    Partial-Bug: 1845522
    Change-Id: I9dfb765d300e86eae1c554703e8e3e4f088d87b7
    Signed-off-by: Bin Qian <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to utilities (master)

Reviewed: https://review.opendev.org/685397
Committed: https://git.openstack.org/cgit/starlingx/utilities/commit/?id=f45ec23405754c35f1a58950f8043d14c355dfbf
Submitter: Zuul
Branch: master

commit f45ec23405754c35f1a58950f8043d14c355dfbf
Author: Bin Qian <email address hidden>
Date: Fri Sep 27 12:12:21 2019 -0400

    Clean up license code

    Remove any license verification and interpretation.

    Closes-Bug: 1845522
    Change-Id: I1ca264311bc8ea0d828ea01c890220641a20e6a5
    Signed-off-by: Bin Qian <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.