Backup & Restore: When merging configuration data on IPv6 during restore bootstrap, duplicated entries are generated

Bug #1845217 reported by Senthil Mukundakumar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Wei Zhou

Bug Description

Brief Description
-----------------
During the active controller restore, in the bootstrap file duplicated entries are created. This cause the active controller restore to fail.

2019-09-23 19:56:20.874 92986 ERROR sysinv.api.controllers.v1.service_parameter [-] WEI value localhost,127.0.0.1,registry.local,[face::2],[face::3],[2620:10a:a001:a103::1085],[2620:10a:a001:a103::1083],[face::4],[2620:10a:a001:a103::1084],[face::2],[face::3],[2620:10a:a001:a103::1085],[2620:10a:a001:a103::1083],[face::4],[2620:10a:a001:a103::1084],tis-lab-registry.cumulus.wrs.com ß It has 290 characters which is more than 255. The following entries are duplicated ([face::3],[2620:10a:a001:a103::1085],[2620:10a:a001:a103::1083],[face::4],[2620:10a:a001:a103::1084])
2019-09-23 19:56:20.874 92986 WARNING wsme.api [-] Client-side error: The service parameter value is restricted to at most 255 characters.

Here is the override file that is generated:

controller-0:/home/sysadmin# more localhost.yml
dns_servers:
  - 2620:10a:a001:a103::2
pxeboot_subnet: 192.168.202.0/24
pxeboot_start_address: 192.168.202.2
pxeboot_end_address: 192.168.202.254
pxeboot_floating_address: 192.168.202.2
pxeboot_node_0_address: 192.168.202.3
pxeboot_node_1_address: 192.168.202.4
management_subnet: face::/64
management_start_address: face::2
management_end_address: face::ffff:ffff:ffff:fffe
management_floating_address: face::2
management_node_0_address: face::3
management_node_1_address: face::4
management_multicast_subnet: ff05::31:0/124
management_multicast_start_address: ff05::31:1
management_multicast_end_address: ff05::31:e
cluster_host_subnet: feed:beef::/64
cluster_host_start_address: feed:beef::2
cluster_host_end_address: feed:beef::ffff:ffff:ffff:fffe
cluster_host_floating_address: feed:beef::2
cluster_host_node_0_address: feed:beef::3
cluster_host_node_1_address: feed:beef::4
cluster_pod_subnet: dead:beef::/64
cluster_pod_start_address: dead:beef::1
cluster_pod_end_address: dead:beef::ffff:ffff:ffff:fffe
cluster_service_subnet: fd04::/112
cluster_sevice_start_address: fd04::1
cluster_service_end_address: fd04::1
external_oam_subnet: 2620:10a:a001:a103::/64
external_oam_start_address: 2620:10a:a001:a103::1
external_oam_end_address: 2620:10a:a001:a103:ffff:ffff:ffff:fffe
external_oam_gateway_address: 2620:10a:a001:a103::6:0
external_oam_floating_address: 2620:10a:a001:a103::1085
external_oam_node_0_address: 2620:10a:a001:a103::1083
external_oam_node_1_address: 2620:10a:a001:a103::1084
docker_no_proxy:
  - "localhost"
  - "127.0.0.1"
  - "registry.local"
  - "[face::2]"
  - "[face::3]"
  - "[2620:10a:a001:a103::1085]"
  - "[2620:10a:a001:a103::1083]"
  - "[face::4]"
  - "[2620:10a:a001:a103::1084]"
  - "tis-lab-registry.cumulus.wrs.com"
docker_http_proxy: http://yow-proxomatic.wrs.com:3128

Severity
--------
Critical: Unable to restore IPV6 configured lab

Steps to Reproduce
------------------
1. Bring up the IPV6 Regular system system
2. Backup the system using ansible locally
4. Re-install the controller with the same load
5. Restore the active controller

Expected Behavior
------------------
The active controller should be successfully restored

Actual Behavior
----------------
Active controller restore failed

Reproducibility
---------------
Reproducible

System Configuration
--------------------
IPv6 configured system

Branch/Pull Time/Commit
-----------------------
 BUILD_ID="2019-09-12_20-00-00"

Test Activity
-------------
Feature Testing

Frank Miller (sensfan22)
summary: - Backup & Restore: When merging configuration data during restore
+ Backup & Restore: When merging configuration data on IPv6 during restore
bootstrap, duplicated entries are generated
Changed in starlingx:
assignee: nobody → Wei Zhou (wzhou007)
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Marking as stx.3.0 gating / high priority as B&R is an stx.3.0 deliverable

tags: added: stx.3.0 stx.config
Changed in starlingx:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Wei Zhou (wzhou007) wrote :

The solution for https://bugs.launchpad.net/starlingx/+bug/1844686 should fix this LP.

Yang Liu (yliu12)
tags: added: stx.retestneeded
Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (master)

Reviewed: https://review.opendev.org/684856
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=0cd64bdc9d8bb1c670ec335d55e7c15431c9260b
Submitter: Zuul
Branch: master

commit 0cd64bdc9d8bb1c670ec335d55e7c15431c9260b
Author: Wei Zhou <email address hidden>
Date: Wed Sep 25 19:43:32 2019 -0400

    Backup & Restore: Active controller restore failed on IPV6 lab

    This commit fixes two bugs:
      1) The square brackets around IPV6 address in the docker_no_proxy list
         should be removed when generating the override file during backup.
      2) Some entries from the addrpool-list are missing in the generated
         override file during backup.

    Change-Id: I981951c51b862ff9f7505ba9b7869dd5813a8830
    Closes-Bug: 1844686
    Closes-Bug: 1845217
    Signed-off-by: Wei Zhou <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Senthil Mukundakumar (smukunda) wrote :

Verified using load 2019-10-28_09-12-55

tags: removed: stx.retestneeded
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.