StarlingX

Eliminate unnecessary imported modules

Bug #1844095 reported by lihang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
lihang

Bug Description

In the config project,"/sysinv/sysinv/sysinv/sysinv/db/" directory has many files imported into the "log" but not used.So I agree we should delete them.

Tags: stx.config
lihang (lihang0166)
Changed in starlingx:
assignee: nobody → lihang (lihang0166)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/682281

Changed in starlingx:
status: New → In Progress
lihang (lihang0166)
summary: - The config has imported modules but is not used
+ Eliminate unnecessary imported modules
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Marking as Low priority / not gating - code cleanup with no functional impact

Changed in starlingx:
importance: Undecided → Low
tags: added: stx.config
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/682281
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=b2198ead7161e7654530230e140dddf11353b4b2
Submitter: Zuul
Branch: master

commit b2198ead7161e7654530230e140dddf11353b4b2
Author: Hang Li <email address hidden>
Date: Mon Sep 16 14:59:14 2019 +0800

    Eliminate unnecessary imported modules

    In the config project,"/sysinv/sysinv/sysinv/sysinv/db/" directory
    has many files imported into the "log" but not used.
    At the same time,I built a system of simplex with the latest ISO
    of the community. When the system was built,the code was changed.
    The system worked well and the other functional modules were not
    affected.So I agree we should delete them.

    Change-Id: Ibe1f96154d6575d701067e43665b336f3bf5bfec
    Partial-Bug: #1844095
    Signed-off-by: Hang Li <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/683840

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/683840
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=67c819eb6206d580e70fb6cd475f9e7e13318470
Submitter: Zuul
Branch: master

commit 67c819eb6206d580e70fb6cd475f9e7e13318470
Author: Hang Li <email address hidden>
Date: Mon Sep 23 11:27:05 2019 +0800

    Eliminate unnecessary imported modules

    In the config project,"/sysinv/sysinv/sysinv/sysinv/helm/" directory
    has many files imported into the "log" but not used.
    At the same time,I built a system of simplex with the latest ISO
    of the community. When the system was built,the code was changed.
    The system worked well and the other functional modules were not
    affected.So I agree we should delete them.

    Change-Id: I7816e54e5a70fe2b2d2b65e7d3a6479378c224d1
    Partial-Bug: #1844095
    Signed-off-by: Hang Li <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/684202

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nfv (master)

Fix proposed to branch: master
Review: https://review.opendev.org/684248

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nfv (master)

Change abandoned by lihang (<email address hidden>) on branch: master
Review: https://review.opendev.org/684248

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/684202
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=bd05f693f244a8a873156a2ef76f7390e1336b18
Submitter: Zuul
Branch: master

commit bd05f693f244a8a873156a2ef76f7390e1336b18
Author: Hang Li <email address hidden>
Date: Tue Sep 24 15:23:30 2019 +0800

    Eliminate unnecessary import modules in the objects directory

    In the config project,"/sysinv/sysinv/sysinv/sysinv/objects/" directory
    has many files imported into the "log" but not used.
    At the same time,I built a system of simplex with the latest ISO
    of the community. When the system was built,the code was changed.
    The system worked well and the other functional modules were not
    affected.So I agree we should delete them.

    Change-Id: I35f35ffdf1b9b00a97c259b47420dee3f1e4d939
    Partial-Bug: #1844095
    Signed-off-by: Hang Li <email address hidden>

Ramaswamy Subramanian (rsubrama)
Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.