DC dcorch platform audit failed at audit_discrepancy

[Andy]

Brief Description
-----------------
In a Distributed Cloud system, when dcorch audit platform, it will failed at
audit_discrepancy() function call.

Severity
--------
Critical: System/Feature is not usable due to the defect

Steps to Reproduce
------------------
- Deploy a DC system with at least one subcloud.
- When the subcloud is online, manage the subcloud by
  dcmanager subcloud manage <subcloud>
- Check /var/log/dcorch/dcorch.log, there will be ERROR like:
  "ERROR dcorch.engine.sync_thread [-] audit_discrepancy() takes exactly 3 arguments (4 given): TypeError: audit_discrepancy() takes exactly 3 arguments (4 given)"

Expected Behavior
------------------
dcorch audit_discrepancy() shouldn't fail.

Actual Behavior
----------------
dcorch audit_discrepancy() failed with ERROR.

Reproducibility
---------------
The issue is 100% reproducible.

System Configuration
--------------------
Distributed Cloud with at least one subcloud, IPv4.

Branch/Pull Time/Commit
-----------------------
StarlingX master, git commit:

commit 8c2bd5fa14a27e488082e50c2957468b600fd1cd
Date: Thu Jul 11 10:56:45 2019 -0400

Last Pass
---------
Did this test scenario pass previously? Unknown

Timestamp/Logs
--------------
2019-08-26 21:20:24.331 104053 INFO dcorch.engine.sync_services.sysinv [-] get_resource_id idns uuid=9fd11ab2-8102-4339-bb56-0144f33fcbd1
2019-08-26 21:20:24.332 104053 INFO dcorch.engine.sync_thread [-] subcloud1/platform: Subcloud resource 9fd11ab2-8102-4339-bb56-0144f33fcbd1 found in master cloud & DB, but the exact same resource not found in subcloud
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread [-] audit_discrepancy() takes exactly 3 arguments (4 given): TypeError: audit_discrepancy() takes exactly 3 arguments (4 given)
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread Traceback (most recent call last):
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread File "/usr/lib/python2.7/site-packages/dcorch/engine/sync_thread.py", line 450, in sync_audit
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread abort_resources)
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread File "/usr/lib/python2.7/site-packages/dcorch/engine/sync_thread.py", line 551, in audit_find_missing
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread resource_type, m_r, sc_resources)
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread TypeError: audit_discrepancy() takes exactly 3 arguments (4 given)
2019-08-26 21:20:24.332 104053 ERROR dcorch.engine.sync_thread

Test Activity
-------------
Found it while doing feature development.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/681853

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681853
Committed: https://git.openstack.org/cgit/starlingx/distcloud/commit/?id=4fc954382048b9f2873a037ea9befd0a366e8c3f
Submitter: Zuul
Branch: master

commit 4fc954382048b9f2873a037ea9befd0a366e8c3f
Author: Andy Ning <email address hidden>
Date: Thu Sep 12 13:26:42 2019 -0400

    Fix dcorch audit_discrepancy() failure

    In a Distributed Cloud system, when dcorch audit platform, it will
    failed at audit_discrepancy() function call. This is because sysinv
    audit_discrepancy() missed the 4th parameter. This update fixed this by
    adding it in.

    Change-Id: I72057b3406b4b362808d241fbc2e43bf07d7b677
    Closes-Bug: 1843770
    Signed-off-by: Andy Ning <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 / high priority as issue impacts Distributed Cloud deployment which is an stx.3.0 feature deliverable