Calico configuration file has yaml format error

[Takeo Komiyama]

Brief Description
-----------------
When run ansible-playbook for bootstrap, in /var/log/daemon.log, it says,

2019-09-06T17:07:29.779 localhost kubelet[851987]: info W0906 17:07:29.779351 851987 cni.go:149] Error loading CNI config list file /etc/cni/net.d/10-calico.conflist: error parsing configuration list: invalid character '"' after object key:value pair

In role template,
/usr/share/ansible/stx-ansible/playbooks/bootstrap/roles/bringup-essential-services/templates/calico-cni.yaml.j2

It seems that "}," are missing at

  cni_network_config: |-
    {
      "name": "k8s-pod-network",
      "cniVersion": "0.3.0",
      "plugins": [
        {
          "type": "calico",
          "log_level": "info",
          "datastore_type": "kubernetes",
          "nodename": "__KUBERNETES_NODE_NAME__",
          "mtu": __CNI_MTU__,
          "ipam": {
            "type": "calico-ipam",
            "assign_ipv4": "{{ "true" if cluster_network_ipv4 else "false" }}",
            "assign_ipv6": "{{ "true" if cluster_network_ipv6 else "false" }}" <-- Here
          "policy": {
              "type": "k8s"
          },

Should be
            "assign_ipv4": "{{ "true" if cluster_network_ipv4 else "false" }}",
            "assign_ipv6": "{{ "true" if cluster_network_ipv6 else "false" }}"
          },
          "policy": {
              "type": "k8s"
          },

Severity
--------
Major

Steps to Reproduce
------------------
Step1: Install STX2.0
Step2: Prepare localhost.yml
Step3: Run ansible-playbook
Step4: See /var/log/daemon.log <-- Show error

Expected Behavior
------------------
No error in kubelet.

Actual Behavior
----------------
Error from kublet

Reproducibility
---------------
Reproducible

System Configuration
---------------
One node system

Branch/Pull Time/Commit
-----------------------

Last Pass
---------

Timestamp/Logs
--------------
Attached localhost.yml

Test Activity
-------------
Evaluation

[Brent Rowsell (brent-rowsell)]

Please attach your localhost.yml

[Ghada Khalil (gkhalil)]

Can you confirm that you are using the build at: http://mirror.starlingx.cengn.ca/mirror/starlingx/release/2.0.0/centos/ ?

Otherwise, if you are building your own load, please provide the branch and date

[Takeo Komiyama (tkomiyam)]

Yes, I used 2.0 release build.
http://mirror.starlingx.cengn.ca/mirror/starlingx/release/2.0.0/centos/

Latest commit in master branch has same issue.
https://opendev.org/starlingx/ansible-playbooks/src/branch/master/playbookconfig/src/playbooks/bootstrap/roles/bringup-essential-services/templates/calico-cni.yaml.j2

[Ghada Khalil (gkhalil)]

Assigning to Tee to triage. I don't think anyone else is reporting this syntax issue. Will wait for her findings before deciding on importance/release gate.

[Al Bailey (albailey1974)]

Needs bracket and a comma.
},

https://opendev.org/starlingx/ansible-playbooks/src/branch/master/playbookconfig/src/playbooks/roles/bootstrap/bringup-essential-services/templates/calico-cni.yaml.j2#L62

Should follow up with Steve to see if this impact his bug
https://bugs.launchpad.net/starlingx/+bug/1840391

Al

[Ghada Khalil (gkhalil)]

Marking as stx.2.0 - It's unclear that there is any impact to this syntax error, but the change is very simple change and would remove the noise from the logs.

Plan to fix in master and cherrypick to r/stx.2.0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/683979

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683979
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=c0e884264a2d7d33a4a3728d0eb71af4577680a7
Submitter: Zuul
Branch: master

commit c0e884264a2d7d33a4a3728d0eb71af4577680a7
Author: Al Bailey <email address hidden>
Date: Fri Sep 20 15:25:49 2019 -0500

    Fix a yaml syntax error in calico CNI configuration

    This correctly updates the yaml and eliminates the
    "error parsing configuration list" from the daemon.log

    Change-Id: Ic7dcbd022af5a57acb95cb098cd7003bc6c79753
    Closes-Bug: 1843453
    Signed-off-by: Al Bailey <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.2.0
Review: https://review.opendev.org/684412

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/684412
Committed: https://git.openstack.org/cgit/starlingx/ansible-playbooks/commit/?id=fd66ac53b2521f96bbcb46e3214b344d9c3200e7
Submitter: Zuul
Branch: r/stx.2.0

commit fd66ac53b2521f96bbcb46e3214b344d9c3200e7
Author: Al Bailey <email address hidden>
Date: Fri Sep 20 15:25:49 2019 -0500

    Fix a yaml syntax error in calico CNI configuration

    This correctly updates the yaml and eliminates the
    "error parsing configuration list" from the daemon.log

    Change-Id: Ic7dcbd022af5a57acb95cb098cd7003bc6c79753
    Closes-Bug: 1843453
    Signed-off-by: Al Bailey <email address hidden>