Docker images pulled that are not required

[Brent Rowsell]

The following images are being pulled by the stx-openstack application which are not used.
The manifest needs to be cleaned up not to pull these images

kolla/ubuntu-source-nova-novncproxy
openstackhelm/ceph-daemon
xrally/xrally-openstack
openstackhelm/neutron
osixia/keepalived
prom/memcached-exporter
docker
kbudde/rabbitmq-exporter
prom/mysqld-exporter

[Al Bailey (albailey1974)]

Here are where some of these are defined:

xrally is being pulled in helm charts as a test image in the following charts:
ceilometer,cinder,glance,heat,keystone,neutron,nova,panko
   test: docker.io/xrally/xrally-openstack:1.3.0

kbudde/rabbitmq-exporter is defined as a prometheus image in the rabbit chart
  prometheus_rabbitmq_exporter: docker.io/kbudde/rabbitmq-exporter:v0.21.0
Note: prometheus is used for metrics gathering.

ingress chart has the keepalived image defined here
keepalived: docker.io/osixia/keepalived:1.4.5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/680067

[Al Bailey (albailey1974)]

This image is still required.
kolla/ubuntu-source-nova-novncproxy

It appears that nova-novnc init pod calls nova-novncproxy-init-assets
which attempts
{"log":"+ cp -vaR '/usr/share/novnc/*' /tmp/usr/share/novnc/\n","stream":"stderr","time":"2019-09-10T18:29:09.855514808Z"}

So a docker image with those files are required, but only during that init phase.

[Al Bailey (albailey1974)]

correction. nova-novncproxy-init-assets should point at a nova image. We should be able to point it at the same version that nova is running.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/683665

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/680067
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=5fee41232ab78fabf5f95e2efd54ecbd1c8b57ff
Submitter: Zuul
Branch: master

commit 5fee41232ab78fabf5f95e2efd54ecbd1c8b57ff
Author: Al Bailey <email address hidden>
Date: Tue Sep 10 08:08:30 2019 -0500

    Add capability to specify null image tags for kube apps

    The openstack-armada-app manifest is being updated
    with null image references to fix this bug for images
    being pulled that are not required.

    The version check has been incremented since the
    openstack-armada-app with these null checks (19)
    would not work if loaded in an older load.

    Change-Id: I57da94e8f27c4f4d32edb764cd6cfb95661a58df
    Partial-Bug: 1841611
    Signed-off-by: Al Bailey <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683665
Committed: https://git.openstack.org/cgit/starlingx/openstack-armada-app/commit/?id=149dcb306dc831d9646b34da3f072f8aeee16211
Submitter: Zuul
Branch: master

commit 149dcb306dc831d9646b34da3f072f8aeee16211
Author: Al Bailey <email address hidden>
Date: Mon Sep 9 08:35:21 2019 -0500

    Cleanup unused docker image references

    The helm charts contain references to images for all
    configurations, however some of those configurations
    are not being enabled, and so the docker images are never
    used.

    This change prevents armada from downloading docker images
    that are not being used by the armada manifest.

    It requires an enhancement in sysinv to handle the null
    reference.

    The following images are unused and have been replaced
    in the manifest with null (or the appropriate reference)

     - kolla/ubuntu-source-nova-novncproxy: referenced by
    novnc_assets and must point to the nova image.

     - xrally/xrally-openstack: used when "test" is enabled,
    referenced by cinder, ceilometer, glance, heat, keystone,
    nova, neutron, panko.

     - openstackhelm/ceph-daemon: referenced by ceph_rgw.

     - openstackhelm/neutron: referenced by openstack-ingress.

     - osixia/keepalived: referenced by openstack-ingress.

     - prom/memcached-exporter: referenced by openstack-memcached.

     - docker: referenced by image_repo_sync image tags in almost
    every chart.

     - kbudde/rabbitmq-exporter: referenced by openstack-rabbitmq.

     - prom/mysqld-exporter: referenced by openstack-mariadb

    Change-Id: Ide26ddaf3537b8b9595104a683339554aea71b48
    Closes-Bug: 1841611
    Depends-On: https://review.opendev.org/#/c/680067/
    Signed-off-by: Al Bailey <email address hidden>