Alarm displaying wrong NTP address when using IPV6

[Ghada Khalil]

Brief Description
-----------------
When setting NTP servers with IPv6, the alarm text doesn't display the full address.

server fd00:4888:2000:1::22
server fd00:4888:2000:1::21

The second address is not actually responding to ntp queries, so the system raises an alarm correctly. However the alarm doesn't display the full address.

fm alarm-list
-------------------------------------------------------------------------------------------------------------------------------------

Alarm ID Reason Text Entity ID Severity Time Stamp
-------------------------------------------------------------------------------------------------------------------------------------

100.114 NTP address fd00:4888:2000: is not a valid or a reachable NTP server. host=controller-1.ntp=fd00: minor 2019-08-14T23:02:51
    4888:2000: .401532

100.114 NTP address fd00:4888:2000: is not a valid or a reachable NTP server. host=controller-0.ntp=fd00: minor 2019-08-14T23:02:07
    4888:2000: .365423

-------------------------------------------------------------------------------------------------------------------------------------

Severity
--------
Minor - display issue

Steps to Reproduce
------------------
- Configure NTP addresses with IPv6
- Specify one address that is not responding, so an alarm is raised

Expected Behavior
------------------
The alarm should display the full IPv6 address

Actual Behavior
----------------
The alarm doesn't display the full IPv6 address. See above.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
Any recent stx load

Last Pass
---------
This never passed

Timestamp/Logs
--------------
Not required. Issue is easily reproducible.

Test Activity
-------------
IPv6 testing

[Ghada Khalil (gkhalil)]

Marking as stx.3.0 - minor issue, but would improve the usability/accuracy for IPv6 configs

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/680105

[Kristine Bujold (kbujold)]

This is an issue with the ntpq command

https://bugs.ntp.org/show_bug.cgi?id=1128

It was fixed in ntp 4.2.8 with the introductions of a "-w" flag.
https://github.com/ntp-project/ntp/commit/aeb3ee65bcd00a4fe5e3d028a45ae8a3fabe134f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/680112

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/680105
Committed: https://git.openstack.org/cgit/starlingx/tools/commit/?id=c778312d0418ede2422951382d06cf0537c03404
Submitter: Zuul
Branch: master

commit c778312d0418ede2422951382d06cf0537c03404
Author: Kristine Bujold <email address hidden>
Date: Wed Sep 4 13:37:19 2019 -0400

    Add ntp-4.2.6p5-28.el7.centos.src.rpm

    Remove the current ntp rpms and add the src.rpm. This is required to fix
    a bug with ntpq and IPV6 addresses.

    Partial-Bug: 1840687

    Change-Id: I0196dda1eaae6d4da0aaa88aa8b487fe1397f3a7
    Signed-off-by: Kristine Bujold <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/680112
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=588e39fe641e0ad938dfcfe76f1df1e81fa244fe
Submitter: Zuul
Branch: master

commit 588e39fe641e0ad938dfcfe76f1df1e81fa244fe
Author: Kristine Bujold <email address hidden>
Date: Wed Sep 4 13:46:57 2019 -0400

    Add new ntp package to build

    This is required to fix a bug with ntpq and IPV6 addresses. The ntpq
    command truncates the remote addresses to 15 characters. This is not
    long enough for IPV6 addresses. This has been fixed in version 4.2.8
    which is not yet released by Centos. Patch
    Fix-ntpq-truncates-IPV6-addresses.patch provides a subset of the fix.

    https://github.com/ntp-project/ntp/commit/aeb3ee65bcd00a4fe5e3d028a45ae8a3fabe134f
    https://bugs.ntp.org/show_bug.cgi?id=1128

    Depends-On: https://review.opendev.org/680105
    Partial-Bug: 1840687

    Change-Id: If9d07acf913ebebead5505d44129f0644511b748
    Signed-off-by: Kristine Bujold <email address hidden>