StarlingX

[Ironic] Cannot do a re-apply on ironic node deployment

Bug #1840031 reported by Jose Perez Carranza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Mingyuan Qi

Bug Description

Brief Description
-----------------
Following the deployment guide [1] for an Ironic node deployment an error is being showed on `application apply` due ironic interface.

1- https://docs.starlingx.io/deploy_install_guides/upcoming/ironic.html

Severity
--------
Major:

Steps to Reproduce
------------------
1. Have Standard StarlingX Deployment correctly provisioned
2. Follow steps to add an Ironic node as described on the wiki
3. After Helm overrides for IRONIC execute `system application-apply stx-openstack`

Expected Behavior
------------------
Application apply should be completed successfully

Actual Behavior
----------------
Application apply is failing

Reproducibility
---------------
Reproducible 100%

System Configuration
--------------------
Standard with extra node for IRONIC

Branch/Pull Time/Commit
-----------------------
OS="centos"
SW_VERSION="19.01"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="20190802T013000Z"

JOB="STX_build_master_master"
<email address hidden>"
BUILD_NUMBER="200"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2019-08-02 01:30:00 +0000"

Last Pass
---------
First time tested

Timestamp/Logs
--------------
Application stx-openstack (1.0-17-centos-stable-versioned) apply started.
2019-08-08 16:06:48.193 141539 INFO sysinv.conductor.kube_app [-] Generating application overrides...
2019-08-08 16:06:51.713 141539 INFO sysinv.helm.neutron [req-8746b196-6d2e-4852-9ce4-4e2ceb50f648 admin admin] _get_neutron_ml2_config={'ml2': {'physical_network_mtus': 'physnet0:1500,physnet1:1500,ironic-data:1500'}, 'ml2_type_flat': {'flat_networks': 'ironic-data'}}
2019-08-08 16:07:03.047 141539 ERROR sysinv.conductor.kube_app [-] 'Connection' object has no attribute 'iinterface_get_by_network'
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app Traceback (most recent call last):
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1780, in perform_app_apply
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app armada_format=True, armada_chart_info=app.charts, combined=True)
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 41, in _wrapper
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app return func(self, *args, **kwargs)
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 521, in generate_helm_application_overrides
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app cnamespace)
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 296, in _get_helm_application_overrides
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app cnamespace)})
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/helm.py", line 201, in _get_helm_chart_overrides
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app cnamespace))
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/ironic.py", line 50, in get_overrides
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app 'network': self._get_network_overrides(),
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/ironic.py", line 158, in _get_network_overrides
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app 'device': str(self._get_ironic_port()),
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/helm/ironic.py", line 114, in _get_ironic_port
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app interface = self.dbapi.iinterface_get_by_network(network.name)
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app File "/usr/lib/python2.7/site-packages/oslo_db/api.py", line 269, in __getattr__
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app attr = getattr(self._backend, key)
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app AttributeError: 'Connection' object has no attribute 'iinterface_get_by_network'
2019-08-08 16:07:03.047 141539 TRACE sysinv.conductor.kube_app
2019-08-08 16:07:03.286 141539 ERROR sysinv.conductor.kube_app [-] Application apply aborted!.
2019-08-08 16:07:03.287 141539 INFO sysinv.conductor.kube_app [-] Deregister the abort status of app stx-openstack

Test Activity
-------------
Feature Testing

Cindy Xie (xxie1)
Changed in starlingx:
assignee: nobody → Mingyuan Qi (myqi)
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Marking as stx.2.0 / high priority given the issue is reproducible. ironic is an stx.2.0 feature deliverable.

Changed in starlingx:
importance: Undecided → High
status: New → Triaged
tags: added: stx.2.0 stx.containers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/676660

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/676660
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=aaa8dd24b63044a8192adcb220c918bc73858991
Submitter: Zuul
Branch: master

commit aaa8dd24b63044a8192adcb220c918bc73858991
Author: Mingyuan Qi <email address hidden>
Date: Thu Aug 15 16:15:44 2019 +0800

    Fix ironic interface get issue

    Get ironic interface from interface_network db since the previous api
    iinterface_get_by_network was removed.

    Closes-Bug: 1840031

    Change-Id: Iecb3e29a656168b391eba145a410e0445e48f1da
    Signed-off-by: Mingyuan Qi <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
Ghada Khalil (gkhalil) wrote :

@Mingyan, please cherrypick the change to the r/stx.2.0 branch asap as this issue is blocking feature test for ironic

Revision history for this message
Mingyuan Qi (myqi) wrote :

@Ghada, done

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (r/stx.2.0)

Fix proposed to branch: r/stx.2.0
Review: https://review.opendev.org/677605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (r/stx.2.0)

Reviewed: https://review.opendev.org/677605
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=6ce738bf26b202a00f02f2fe898a585b2f3a54f4
Submitter: Zuul
Branch: r/stx.2.0

commit 6ce738bf26b202a00f02f2fe898a585b2f3a54f4
Author: Mingyuan Qi <email address hidden>
Date: Thu Aug 15 16:15:44 2019 +0800

    Fix ironic interface get issue

    Get ironic interface from interface_network db since the previous api
    iinterface_get_by_network was removed.

    Closes-Bug: 1840031

    Change-Id: Iecb3e29a656168b391eba145a410e0445e48f1da
    Signed-off-by: Mingyuan Qi <email address hidden>

Ghada Khalil (gkhalil)
tags: added: in-r-stx20
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.