collect missing files and data under /var/extra

[Kristine Bujold]

Title
-----
collect missing files and data under /var/extra

Brief Description
-----------------

Some collect scripts have the nodetype variable as blank. Because of this not all information is being collected. Some files are missing data such as the networking.info file and some files are not created such as the openstack.info file. The /var/extra/platform is also missing. Files missing from /var/extra/ are;

   platform
   database/barbican.db.sql.txt
   database/fm.db.sql.txt
   database/postgres.db.sql.txt
   database/sysinv.db.sql.txt
   alarms.info
   ceph.info
   barbican.db.sql.txt
   fm.db.sql.txt
   postgres.db.sql.txt
   sysinv.db.sql.txt
   database.info
   inventory.info
   nfv-vim.info
   openstack.info
   ovs.info
   platform
   rpm.info
   sm.info

Severity
--------
Minor

Steps to Reproduce
------------------
Execute the collect command

Expected Behavior
------------------
Data should be collect as expected.

Actual Behavior
----------------
See above

Reproducibility
---------------
Reproducible

System Configuration
--------------------
All

Branch/Pull Time/Commit
-----------------------
https://opendev.org/starlingx/integ/commit/c57df403cea01e02a4d111b40558d33825e8293d

Timestamp/Logs
--------------
NA

[Frank Miller (sensfan22)]

Marking medium priority and stx.3.0 gating.

[Eric MacDonald (rocksolidmtce)]

Was this found before or after the following commit ?

https://review.opendev.org/#/c/672149/

This update may fix this issue.

[Kristine Bujold (kbujold)]

After. "source_openrc_if_needed" is required for other collect scripts as well

  tools/collector/scripts/collect_ceph.sh
  tools/collector/scripts/collect_fm.sh
  tools/collector/scripts/collect_networking.sh
  tools/collector/scripts/collect_nfv_vim.sh
  tools/collector/scripts/collect_openstack.sh
  tools/collector/scripts/collect_ovs.sh
  tools/collector/scripts/collect_patching.sh
  tools/collector/scripts/collect_psqldb.sh
  tools/collector/scripts/collect_sm.sh
  tools/collector/scripts/collect_sysinv.sh

[Eric MacDonald (rocksolidmtce)]

Yes, if source_openrc_if_needed is there then you have the change.

Those scripts should inherit the collect env

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/676215

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676215
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=adda44b54ea0e0535e330ed4c38c1ed4105ad43d
Submitter: Zuul
Branch: master

commit adda44b54ea0e0535e330ed4c38c1ed4105ad43d
Author: Eric MacDonald <email address hidden>
Date: Tue Aug 13 11:16:10 2019 -0400

    Make platform.conf variables visible to collect.d service scripts

    A number of collect.d service scripts are not gathering
    all the info that is needed during the collect operation.

    Many collect.d service scripts use nodetype, subfunction,
    vswitch_type and other platform.conf variables to determine
    what to collect.

    However, these variables are seen to be empty causing the
    service scripts to make incorrect collection decisions.

    This update modifies the scoping of loaded platform.conf
    variables so that they are visible to all of collect,
    including the collect.d service scripts.

    Test Plan:

    PASS: Verify platform.conf variables are visible to collect.d service scripts.
    PASS: Verify file list before and after update.
    PASS: Run collect all and verify missing content present.
    PASS: Run collect host and verify missing content present.

    Change-Id: Ia6f45afd3f3fc676b0d3eaca16dc8bbe68356c8e
    Closes-Bug: 1839389