There is a clerical error in function signal_hdlr_init of pmon.

Bug #1838004 reported by YeHuiSheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Wishlist
YeHuiSheng

Bug Description

In the function signal_hdlr_init of pmonHdlr.cpp, the parameter of sizeof function must be _pmon_ctrl_ptr->info.

memset (&_pmon_ctrl_ptr->prev, 0, sizeof(_pmon_ctrl_ptr->info));

Although the values of sizeof(_pmon_ctrl_ptr->info) and sizeof(_pmon_ctrl_ptr->prev) are the same, but I think it still be a clerical error.

So we need to modify the clerical error to make the code be readable.

Tags: stx.metal
YeHuiSheng (hsye)
Changed in starlingx:
assignee: nobody → YeHuiSheng (hsye)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master)

Fix proposed to branch: master
Review: https://review.opendev.org/672934

Changed in starlingx:
status: New → In Progress
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low priority / Not Gating - code cleanup suggestion / no noted system impact

tags: added: stx.metal
Changed in starlingx:
importance: Undecided → Low
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/672934
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=9a6c6340ebb2926d4195807d6574e96c4a634b11
Submitter: Zuul
Branch: master

commit 9a6c6340ebb2926d4195807d6574e96c4a634b11
Author: YeHuiSheng <email address hidden>
Date: Fri Jul 26 17:44:46 2019 +0800

    Modify a clerical error to make the code be readable.

    Change-Id: I1b3e413bb626267298fee69cc935a95115e1fb9d
    Closes-Bug: #1838004
    Signed-off-by: YeHuiSheng <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.