If user trigger an unlock when stx-openstack is reapplying, the unlock_ready flag should not be removed.

[Yan Chen]

Test steps:
1. deploy starlingx infrastructure for a simplex system and apply stx-openstack.
2. lock the controller-0.
3. unlock controller-0, this operation will trigger the stx-openstack reapply.
3. before the reapply finished, unlock controller-0 again.

Expected Result:
As stx-openstack is already under reapplying, the new unlock operation will not trigger the reapply again, and the unlock_ready flag should not be removed.

Actual Result:
The reapply is not triggered again.
But unlock_ready flag is removed again, although the flag is already removed by the former unlock.

This is a logic error, though impact is low.

[Yan Chen (ychen2u)]

From the last piece of the attached file, we can see the following log:

2019-07-04 15:46:54.702 112183 INFO sysinv.api.controllers.v1.host [-] controller-0 Action unlock perform notify_mtce
2019-07-04 15:46:54.708 112183 INFO sysinv.api.controllers.v1.host [-] Remove unlock ready flag
....
2019-07-04 15:46:54.743 112183 INFO sysinv.api.controllers.v1.rest_api [-] Response={u'status': u'pass'}
2019-07-04 15:46:54.784 112183 INFO sysinv.api.controllers.v1.host [-] stx-openstack system app is present but not applied, skipping re-apply

Removal of unlock_ready is triggered but app reapply is not.
These 2 operations should be aligned.

[Ghada Khalil (gkhalil)]

@ychen2u, what is the system impact of this issue?

[Yan Chen (ychen2u)]

Currently there's no obvious impact on the system.
But if a user do unlock twice when the first unlock is still on-going, there might be a competition on the unlock_ready flag.

This issue can be fixed with the following patch.
https://review.opendev.org/#/c/669278/

[Frank Miller (sensfan22)]

This issue is part of a set of issues with application apply/re-apply. LP https://bugs.launchpad.net/starlingx/+bug/1837750 is tracking a set of changes to improve the re-apply logic and will include a fix for this 1837343 as well. My recommendation is to abandon the current proposed commit and mark 1837343 as a duplicate of 1837750.

Also as this is impacting containers and is reproducible, adding the stx.2.0 gating tag.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yan Chen (<email address hidden>) on branch: master
Review: https://review.opendev.org/669278
Reason: Abandon this commit as Frank recommended.

[Yan Chen (ychen2u)]

Abandon this commit as Frank recommended.
https://review.opendev.org/#/c/669278/

[Yan Chen (ychen2u)]

Duplicated with https://bugs.launchpad.net/starlingx/+bug/1837750.

[Ghada Khalil (gkhalil)]

Duplicate bug has been addressed in master & the r/stx.2.0 branch. Marking as "Fix Released" to match.