stx-openstack developer charts upload rejected

[Daniel Badea]

Brief Description
-----------------
stx-config commit 1ced1ec2b9cdeb2fa05764982b46974ab92c62fa is adding version check application upload:

https://opendev.org/starlingx/config/src/commit/1ced1ec2b9cdeb2fa05764982b46974ab92c62fa/sysinv/sysinv/sysinv/sysinv/helm/openstack_version_check.py

compares stx-openstack version against:

SUPPORTED_VERSIONS = {
    '1.0-17-centos-stable-versioned',
    '1.0-17-centos-stable-latest',
}

but charts generated with $MY_REPO_ROOT_DIR/cgcs-root/build-tools/build-helm-charts.sh according to official docs (for example https://docs.starlingx.io/deploy_install_guides/upcoming/aio_simplex.html ) is creating an archive with version:

'1.0-17'

so it fails at upload:

"Unsupported version reported by version_check: stx-openstack 1.0-17"

Severity
--------
critical (can proceed after patching openstack_version_check.py to accept version '1.0-17' and restarting sysinv conductor)

Steps to Reproduce
------------------
Build an image, install it, wait for platform to become available, try to upload stx-openstack generated in the same workspace.

Expected Behavior
------------------
stx-openstack upload successful

Actual Behavior
----------------
upload failed

Reproducibility
---------------
100%

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
2019-07-18

Last Pass
---------
2019-07-11

Timestamp/Logs
--------------
2019-07-18 17:50:41.109 118956 INFO sysinv.api.controllers.v1.kube_app [-] Tar file of application stx-openstack verified.
2019-07-18 17:50:41.217 115777 INFO sysinv.conductor.kube_app [-] Application stx-openstack (1.0-17) upload started.
2019-07-18 17:50:41.218 115777 INFO sysinv.helm.helm [req-c361e87c-e454-40ac-bdc4-609c6410b7d7 admin admin] Unsupported version reported by version_check: stx-openstack 1.0-17
2019-07-18 17:50:41.218 115777 INFO sysinv.conductor.kube_app [-] Application stx-openstack (1.0-17) upload rejected. Unsupported version.
2019-07-18 17:50:41.219 115777 ERROR sysinv.conductor.kube_app [-] Upload of application stx-openstack (1.0-17) failed: Unsupported application version.
2019-07-18 17:50:41.219 115777 TRACE sysinv.conductor.kube_app Traceback (most recent call last):
2019-07-18 17:50:41.219 115777 TRACE sysinv.conductor.kube_app File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1471, in perform_app_upload
2019-07-18 17:50:41.219 115777 TRACE sysinv.conductor.kube_app reason="Unsupported application version.")
2019-07-18 17:50:41.219 115777 TRACE sysinv.conductor.kube_app KubeAppUploadFailure: Upload of application stx-openstack (1.0-17) failed: Unsupported application version.
2019-07-18 17:50:41.219 115777 TRACE sysinv.conductor.kube_app
2019-07-18 17:50:41.303 115777 ERROR sysinv.conductor.kube_app [-] Application upload aborted!.
2019-07-18 17:50:41.305 115777 ERROR sysinv.openstack.common.rpc.amqp [req-c361e87c-e454-40ac-bdc4-609c6410b7d7 admin admin] Exception during message handling
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp Traceback (most recent call last):
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/amqp.py", line 438, in _process_data
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp **args)
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp result = getattr(proxyobj, method)(ctxt, **kwargs)
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 10244, in perform_app_upload
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp self._app.perform_app_upload(rpc_app, tarfile)
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp File "/usr/lib64/python2.7/site-packages/sysinv/conductor/kube_app.py", line 1471, in perform_app_upload
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp reason="Unsupported application version.")
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp KubeAppUploadFailure: Upload of application stx-openstack (1.0-17) failed: Unsupported application version.
2019-07-18 17:50:41.305 115777 TRACE sysinv.openstack.common.rpc.amqp

Test Activity
-------------
Developer testing

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/671745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/671745
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=e5a9f0ed8ee8342fbd4b83f8ecd75aaf3145ce5a
Submitter: Zuul
Branch: master

commit e5a9f0ed8ee8342fbd4b83f8ecd75aaf3145ce5a
Author: Don Penney <email address hidden>
Date: Fri Jul 19 09:59:48 2019 -0400

    Add 1.0-17 to supported stx-openstack app version list

    The formal CENGN build uses the --label option when building
    the application tarballs, resulting in application versions of:
    - 1.0-17-centos-stable-versioned
    - 1.0-17-centos-stable-latest

    These versions were added to the new application version check
    in the following update:
    https://review.opendev.org/670754

    When the --label is not specified, however, the version does not
    include a label. So most developer application build will just
    have a version set to "1.0-17" (as a current example).

    This update adds this version to the supported version list to
    allow for developers using custom builds.

    Change-Id: Ifb26e2f391a0195fc53d65b8adf8f87cb87f68e5
    Closes-Bug: 1837105
    Signed-off-by: Don Penney <email address hidden>

[Ghada Khalil (gkhalil)]

Marking as stx.2.0 gating / high priority as this issue was introduced by a recent code change ( https://review.opendev.org/670754 ) and it impacts developer testing