There is a memory leak bug in Pmon alarm

Bug #1836130 reported by YeHuiSheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
YeHuiSheng

Bug Description

When the system launch pmond process, it will malloc memory which is pointed by a temporary variable "alarm_list_ptr" in function "manage_queried_alarms".
However, there is no list or free function called in "manage_queried_alarms".
When the function "manage_queried_alarms" is finished, the temporary variable "alarm_list_ptr" will be unusable.
Then the memory must be leaked.

Fortunately,the function "manage_queried_alarms" will be called only once in the pmond.
So, it will waste only a little memory.

Tags: stx.metal
YeHuiSheng (hsye)
description: updated
YeHuiSheng (hsye)
Changed in starlingx:
assignee: nobody → YeHuiSheng (hsye)
Changed in starlingx:
status: New → In Progress
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low priority / not gating - would be nice to fix as it is related to a memory leak, but likely the leak is small and doesn't cause any negative system impact

Changed in starlingx:
importance: Undecided → Low
tags: added: stx.metal
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/670012
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=7875130a80aa2b1df3ddd769bde1f68aabe4c392
Submitter: Zuul
Branch: master

commit 7875130a80aa2b1df3ddd769bde1f68aabe4c392
Author: YeHuiSheng <email address hidden>
Date: Wed Jul 10 16:19:06 2019 +0800

    Modify a memory leak bug in Pmon alarm.

    Add a free call after malloc in the Pmon alarm module.

    Change-Id: I2ca948f28959e1b99f19777410b2f906b27a3e2e
    Closes-Bug: #1836130
    Signed-off-by: YeHuiSheng <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.