Remove all references to /etc/nova/instances

[Gerry Kopec]

With move to containers, nova instances have moved from /etc/nova/instances to /var/lib/nova/instances.

However there are still some references to /etc/nova/instances in our code base which should be cleaned up or assessed to ensure there is not functional impact:
-bash-4.2$ pwd
/localdisk/designer/gkopec/starlingx-0-jun19/cgcs-root/stx

-bash-4.2$ grep -rsI /etc/nova/instances
stx-integ/config-files/rsync-config/files/rsyncd.conf: path = /etc/nova/instances
stx-integ/monitoring/collectd-extensions/src/df.conf: MountPoint "/etc/nova/instances"
stx-integ/tools/collector/scripts/collect_host:for i in /etc/nova/instances/*/console.log; do
stx-config/workerconfig/workerconfig/worker_config: cp -Rp $MATE_INSTANCES_DIR/* /etc/nova/instances/
stx-fault/fm-doc/fm_doc/events.yaml:# 100.105: Retired (with R2 release): previously monitored /etc/nova/instances

Looking at these they seem to relate to collect and backup/restore.

[Frank Miller (sensfan22)]

This issue means that VM console and other data will be missing from the collect tool. Based on that my recommendation is this should be stx.2.0 gating.

[Ghada Khalil (gkhalil)]

Marking as stx.2.0 gating based on Frank's recommendation as this will negatively affect issue triage/investigation

[Frank Miller (sensfan22)]

Reviewed by the containers PL (Frank) and TL (Brent) and changed priority to high. For future debugability we will require the nova console information in the collect logs for some types of bugs reported by users of StarlingX. As such this LP is required for stx.2.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/674181

[Gerry Kopec (gerry-kopec)]

This commit, https://review.opendev.org/#/c/671661/, fixed this case:
stx-integ/monitoring/collectd-extensions/src/df.conf: MountPoint "/etc/nova/instances"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/674181
Committed: https://git.openstack.org/cgit/starlingx/integ/commit/?id=86b412adb00ba3afff87793196cef669a8dc61c8
Submitter: Zuul
Branch: master

commit 86b412adb00ba3afff87793196cef669a8dc61c8
Author: Gerry Kopec <email address hidden>
Date: Fri Aug 2 00:50:12 2019 -0400

    Fix collect script to capture VM console logs

    VM console.log files were moved when we cutover to containers config.
    Update collect script accordingly.

    Change-Id: Ic430588efd90a8c5df41dc7c32724d7bacd88bcd
    Partial-Bug: 1835567
    Signed-off-by: Gerry Kopec <email address hidden>

[Gerry Kopec (gerry-kopec)]

Marking as Fix Released as committed changes address comments 1-3.