DEPRECATION WARNING for pep8

Bug #1835386 reported by junboli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
junboli

Bug Description

When execute tox -e pep8, we find there are DEPRECATION WARNING as following:

[root@localhost nfv]# tox -e pep8
pep8 installed: Babel==2.7.0,bashate==0.6.0,mock==3.0.5,nose==1.3.7,pathspec==0.5.9,pbr==5.3.1,pytz==2019.1,PyYAML==5.1.1,six==1.12.0,yamllint==1.16.0
pep8 run-test-pre: PYTHONHASHSEED='140358159'
pep8 run-test: commands[0] | find /home/commit/nfv -type f -not -path '/home/commit/nfv/.tox/*' -not -path '*/__pycache__/*' -name '*.py[c|o]' -delete
WARNING: test command found but not installed in testenv
  cmd: /usr/bin/find
  env: /home/commit/nfv/.tox/pep8
Maybe you forgot to specify a dependency? See also the whitelist_externals envconfig setting.

DEPRECATION WARNING: this will be an error in tox 4 and above!
__________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
  pep8: commands succeeded
  congratulations :)

Tags: stx.nfv
junboli (junboli)
Changed in starlingx:
assignee: nobody → junboli (junboli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nfv (master)

Fix proposed to branch: master
Review: https://review.opendev.org/669116

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to update (master)

Fix proposed to branch: master
Review: https://review.opendev.org/669119

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nfv (master)

Reviewed: https://review.opendev.org/669116
Committed: https://git.openstack.org/cgit/starlingx/nfv/commit/?id=4d6ff3de71f12d2c5b4d1fc913ab7f6b3da924d9
Submitter: Zuul
Branch: master

commit 4d6ff3de71f12d2c5b4d1fc913ab7f6b3da924d9
Author: junboli <email address hidden>
Date: Thu Jul 4 10:27:56 2019 -0400

    Fix DEPRECATION WARNING for pep8

    When we execute pep8 locally, we find there is
    DEPRECATION WARNING, This warning will be an error
    in tox4 and above, this change is to fix this.

    Change-Id: Iaebe8ffe3aa1b92956403c679600fad0098d8329
    Partial-Bug: #1835386
    Signed-off-by: junboli <email address hidden>

Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low priority / not gating any starlingx release -- fix to a pep8 warning; doesn't have any system impact at this time

Changed in starlingx:
importance: Undecided → Low
Revision history for this message
Ghada Khalil (gkhalil) wrote :

@junboli, Is the above review the only code change required to address this bug? If so, please mark the status as "Fix Released"

In the future, if one review is needed, please use "Closes-Bug: " instead of "Partial-Bug: " in the commit message. This updates the bug automatically to the correct status.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to update (master)

Reviewed: https://review.opendev.org/669119
Committed: https://git.openstack.org/cgit/starlingx/update/commit/?id=7ff00cc5efba22eb964e58a92817c44da80cd226
Submitter: Zuul
Branch: master

commit 7ff00cc5efba22eb964e58a92817c44da80cd226
Author: junboli <email address hidden>
Date: Thu Jul 4 05:19:00 2019 -0400

    Add 'find' in whitelist_externals in tox.ini

    Running tox is giving a warning because the tox.ini is
    using "find", but the find command is not whitelisted.

    Change-Id: I38ece01f6135ebb38a94b9d835e2708a02b35805
    Closes-bug: #1835386
    Signed-off-by: junboli <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.