Fix minor issues in metal

Bug #1835370 reported by Tao Li on 2019-07-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Low
Tao Li

Bug Description

Brief Description
-----------------
There is some minor coding issues in metal, this bug report is tracing these issues fiexed.

Severity
--------
minor

Steps to Reproduce
------------------

Expected Behavior
------------------

Actual Behavior
----------------

Reproducibility
---------------

System Configuration
--------------------
STD system

Branch/Pull Time/Commit
-----------------------
master

Tao Li (eric-litao) on 2019-07-04
Changed in starlingx:
assignee: nobody → Tao Li (eric-litao)
status: New → In Progress
Ghada Khalil (gkhalil) wrote :

Low priority / not gating any starlingx release -- code improvement; doesn't have any system impact

tags: added: stx.metal
Changed in starlingx:
importance: Undecided → Low

Fix proposed to branch: master
Review: https://review.opendev.org/669998

Reviewed: https://review.opendev.org/669097
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=c74d50c152446ce701727db01e80f5d63dce01ce
Submitter: Zuul
Branch: master

commit c74d50c152446ce701727db01e80f5d63dce01ce
Author: Tao Li <litao3721@126.com>
Date: Thu Jul 4 16:21:40 2019 +0800

    Fix the log issue in config handler

    The logged config file is not the parsed config file.

    Change-Id: I72257331f58811167d98a08b9032c51aa4b6681a
    Partial-Bug: #1835370
    Signed-off-by: Tao Li <litao3721@126.com>

Reviewed: https://review.opendev.org/669998
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=73146540e2516e3c1e1f4dec38c94b0171946791
Submitter: Zuul
Branch: master

commit 73146540e2516e3c1e1f4dec38c94b0171946791
Author: Tao Li <litao3721@126.com>
Date: Wed Jul 10 15:25:07 2019 +0800

    Add the mask check for the loaded config

    If some config is not loaded, we can't get the default value,
    so we must ensure all the configs are loaded.

    Change-Id: I198af4fac6f873d3e7785d2105d14898be084d48
    Partial-Bug: #1835370
    Signed-off-by: Tao Li <litao3721@126.com>

Reviewed: https://review.opendev.org/692222
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=e356019f954136f597d7fb00e4d972c2535ad504
Submitter: Zuul
Branch: master

commit e356019f954136f597d7fb00e4d972c2535ad504
Author: Don Penney <email address hidden>
Date: Wed Oct 30 16:40:56 2019 -0400

    Update host watchdog CONFIG_MASK

    The CONFIG_MASK in hostw.h includes CONFIG_START_DELAY, which
    correlates to an option that is not actually used in host watchdog. As
    a result, the recently added check that verifies all options in the
    CONFIG_MASK are set fails, and the host watchdog fails to launch.

    This update removes the unused CONFIG_START_DELAY bit from
    CONFIG_MASK.

    Change-Id: I330e15520bc0f01a6cbfd4f83a1953c1c737da2b
    Partial-Bug: 1835370
    Signed-off-by: Don Penney <email address hidden>

Change abandoned by Eric MacDonald (<email address hidden>) on branch: master
Review: https://review.opendev.org/669968
Reason: This update is stale. Abandoning.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers