StarlingX

No return value for disk_format_gpt

Bug #1835069 reported by junboli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
junboli

Bug Description

There are no return value in self._idisk_operator.disk_format_gpt(xxx, xxxx), so there is no need to return the invoking.

Tags: stx.config
junboli (junboli)
Changed in starlingx:
assignee: nobody → junboli (junboli)
OpenStack Infra (hudson-openstack)
Changed in starlingx:
status: New → In Progress
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Low priority / not gating any starlingx release. code cleanup without any functional impact

Changed in starlingx:
importance: Undecided → Low
tags: added: stx.config
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/668391
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=a95dfc6e3ae7e3e7ac83a5b416178649be368321
Submitter: Zuul
Branch: master

commit a95dfc6e3ae7e3e7ac83a5b416178649be368321
Author: junboli <email address hidden>
Date: Tue Jul 2 22:12:22 2019 -0400

    Remove the return value for disk_format_gpt

    In the method self._idisk_operator.disk_format_gpt(xxx, xxxx), there
    are no return value, so there is no need to return this method.

    Also, I am using the latest iso with this changing code to execute
    the system API command:
      $ system host-disk-wipe 1 81b74bfd-f5cc-4871-878f-83e3cfb081b2
    it works all right.

    Closes-bug: #1835069
    Change-Id: I90e0ba940c64ca0872f3597488976fb09c16c389
    Signed-off-by: junboli <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.