Cleaning up dead code as result of switch to Ansible
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
Angie Wang |
Bug Description
Brief Description
-----------------
As result of switching to Ansible for bootstrap configuration config_controller and some of puppet files are no longer required. We need to remove the dead code as it can lead to confusion and mistakes.
Severity
--------
Major:It can potentially lead to cause designer mistakes.
Steps to Reproduce
------------------
NA
Expected Behavior
------------------
NA
Actual Behavior
----------------
NA
Reproducibility
---------------
Reproducible
System Configuration
-------
All
Branch/Pull Time/Commit
-------
Master
Last Pass
---------
NA
Timestamp/Logs
--------------
NA
Test Activity
-------------
Feature development
Changed in starlingx: | |
assignee: | nobody → Tee Ngo (teewrs) |
Ghada Khalil (gkhalil) wrote : | #1 |
Changed in starlingx: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: | added: stx.2.0 stx.config |
tags: | removed: stx.2.0 |
Changed in starlingx: | |
assignee: | Tee Ngo (teewrs) → Angie Wang (angiewang) |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master) | #2 |
Fix proposed to branch: master
Review: https:/
Changed in starlingx: | |
status: | Triaged → In Progress |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (master) | #3 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master) | #4 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master) | #5 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (master) | #6 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3d6483194e843c9
Author: Angie Wang <email address hidden>
Date: Fri Jan 17 15:07:39 2020 -0500
Remove the dependency of controllerconfig
As controllerconfig is being cleaned up, remove the dependency
of controllerconfig in Ansible playbook. This commit also copies
over the registry cert template from puppet as it's only been
used at bootstrap time.
Change-Id: I820d968629a920
Closes-Bug: 1834218
Signed-off-by: Angie Wang <email address hidden>
Changed in starlingx: | |
status: | In Progress → Fix Released |
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master) | #7 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 27f167eb14a04bc
Author: Angie Wang <email address hidden>
Date: Wed Jan 15 16:15:26 2020 -0500
Remove puppet-manifests code made obsolete by ansible
As a result of switch to Ansible, remove the obsolete erb
templates and remove the dependency of is_initial_
facter.
Change-Id: I4ca6525f01a37d
Partial-Bug: 1834218
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master) | #8 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit f5e43997e398f0a
Author: Angie Wang <email address hidden>
Date: Thu Jan 9 16:45:22 2020 -0500
Clean up dead code in controllerconfig
This commit updates to clean up the obsolete code in
controllerc
The cleanup includes:
- the whole config_controller with its relevant files
- config_subcloud
- config_region
Tests conducted:
- fresh installation of AIO-SX, AIO-DX, standard
and storage labs
- platform sanity performed on AIO-SX, AIO-DX,
standard and storage labs
- stx-openstack app apply/remove performed on AIO-SX
and AIO-DX
- stx-monitor app apply/remove on standard and
storage labs
- backup&restore performed on standard lab
- distributed cloud was deployed
Change-Id: I0d1eb91188dfb2
Partial-Bug: 1834218
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master) | #9 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit eff0d663776587a
Author: Angie Wang <email address hidden>
Date: Mon Jan 20 15:09:10 2020 -0500
Remove unused post_clone_
Change-Id: I3be9384b94473c
Partial-Bug: 1834218
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master) | #10 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master) | #11 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1f0706ee30f44c6
Author: Don Penney <email address hidden>
Date: Mon Feb 3 12:48:03 2020 -0500
Drop clone.py references from boot menu comment blocks
As part of recent code cleanup activities, the controllerconfig
clone.py module was dropped. This update removes references to this
file from the comment blocks of the boot menu files grub.cfg and
centos.
Change-Id: If2260c74f58a61
Partial-Bug: 1834218
Signed-off-by: Don Penney <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (f/centos8) | #12 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8) | #13 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (f/centos8) | #14 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #15 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (f/centos8) | #16 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit bf8d081a95a9b17
Author: Angie Wang <email address hidden>
Date: Thu Jan 30 17:57:05 2020 -0500
Support k8s networking upgrade based on k8s version
Update to support a set of k8s networking templates
based on kubernetes release. The kubernetes version
needs to be passed to the ansible playbook
k8s-
of networking manifests should be applied for the
current kubernetes.
Story: 2006781
Task: 37584
Change-Id: I3a0b9f56608ddb
Signed-off-by: Angie Wang <email address hidden>
commit 2b0cd43e5fa7562
Author: Jerry Sun <email address hidden>
Date: Thu Dec 19 13:22:50 2019 -0500
Add Dex parameters to ansible bootstrap
Add oidc_groups_claim as a new parameters for ansible
config. We now have 2 valid configs: the previous 3 parameters
for a microsoft azure authentication deployment, and the previous
3 in addition to oidc_groups_claim for a dex authentication
deployment.
Story: 2006711
Task: 37850
Change-Id: I265d2f7872eb31
Depends-On: https:/
Signed-off-by: Jerry Sun <email address hidden>
commit 92ca12265273380
Author: David Sullivan <email address hidden>
Date: Wed Jan 22 21:33:19 2020 -0500
Install secondary controller nodes with kubeadm join
Kubeadm init is no longer supported for installing secondary nodes in an
HA kubernetes cluster. kubeadm join with the --controller-plane option
should be used.
Change-Id: I64aaf02b090536
Partial-Bug: 1846829
Depends-On: https:/
Signed-off-by: David Sullivan <email address hidden>
commit 393379bd7671aee
Author: Angie Wang <email address hidden>
Date: Tue Jan 28 14:01:10 2020 -0500
Fix the image download failure on IPv6 system
"crictl pull" failed to pull images on IPv6 system with
proxy setting since Containerd doesn't work with the
NO_PROXY environment variable that has IPv6 addresses
with square brackets. This commit updates to strip out
the square brackets from NO_PROXY environment variable.
Verified on both IPv4 and IPv6 labs.
Change-Id: I70bd00439b2cc3
Partial-Bug: 1859835
Signed-off-by: Angie Wang <email address hidden>
commit 792ea357e2b6d2b
Author: Jim Somerville <email address hidden>
Date: Mon Jan 27 16:08:48 2020 -0500
Security: Add nospectre_v1 to the default setting
Most of the v1 mitigation is baked into the kernel and not
optional. The swapgs barriers are, however, optional.
They have a negative performance impact so we disable them
by using the nospectre_v1 kernel bootarg.
C...
tags: | added: in-f-centos8 |
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8) | #17 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 7995dd436954b92
Author: Jessica Castelino <email address hidden>
Date: Mon Feb 3 12:07:26 2020 -0500
Unit test cases for helm charts
Test cases added for API endpoints used by:
1. helm-override-
2. helm-override-show
3. helm-override-list
4. helm-override-
5. helm-chart-
Story: 2007082
Task: 38012
Change-Id: I86763496bb4108
Signed-off-by: Jessica Castelino <email address hidden>
commit 7e2fda010299f73
Author: Angie Wang <email address hidden>
Date: Wed Jan 29 21:18:18 2020 -0500
Finish kubernetes networking upgrade support
The commit completes the RPC kube_upgrade_
in sysinv-conductor to run ansible playbook
upgrade-
and also updates the networking upgrade function called
as part of sysinv-conductor startup to provide a current
kubernetes version when running the upgrade playbook.
The second control plane upgrade can only be performed
after the networking upgrade is done, fix the semantic
check in sysinv api.
Change-Id: I8dcf5a2baedfae
Story: 2006781
Task: 37584
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
commit 52c37a35d2cd62f
Author: Jerry Sun <email address hidden>
Date: Fri Jan 31 16:10:25 2020 -0500
Add Unit Tests for Dex Sysinv Changes
Add unit tests for the dex helm chart changes under the same story
and task
Story: 2006711
Task: 37857
Depends-On: https:/
Change-Id: I3a0e1c490e5618
Signed-off-by: Jerry Sun <email address hidden>
commit 144587a6ac9fc48
Author: Teresa Ho <email address hidden>
Date: Fri Jan 31 15:35:04 2020 -0500
Tox tests for OIDC client helm overrides
Added some tox tests for OIDC client helm overrides.
Story: 2006711
Task: 38481
Change-Id: If4aeaf0010c707
Signed-off-by: Teresa Ho <email address hidden>
commit 763ddeadd4e83af
Author: Thomas Gao <email address hidden>
Date: Wed Jan 29 16:30:40 2020 -0500
Fixed errors in address deletion
Allowed address deletion despite missing associated interface or host.
Enabled relevant unit test.
Closes-Bug: 1860186
Change-Id: Ie6e6358aa75091
Signed-off-by: Thomas Gao <email address hidden>
commit 61463608169e756
Author: Thomas Gao <email address hidden>
Date: Tue Jan 28 15:32:58 2020 -0500
Fixed broken sysinv address get-all api call
Removed unexpected keyword argument that caused the error....
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8) | #18 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit fc7b9b3d8d811fd
Author: Angie Wang <email address hidden>
Date: Tue Jan 28 13:57:52 2020 -0500
Fix the image download failure on IPv6 system
"crictl pull" failed to pull images on IPv6 system with
proxy setting since Containerd doesn't work with the
NO_PROXY environment variable that has IPv6 addresses
with square brackets. This commit updates to strip out
the square brackets from NO_PROXY environment variable.
Change-Id: I6bb5ad0379f576
Closes-Bug: 1859835
Signed-off-by: Angie Wang <email address hidden>
commit 950670ac1f0bfaa
Author: Jim Somerville <email address hidden>
Date: Mon Jan 27 17:09:52 2020 -0500
Security: Add nospectre_v1 to the security params
Most of the v1 mitigation is baked into the kernel and not
optional. The swapgs barriers are, however, optional.
They have a negative performance impact so we disable them
by using the nospectre_v1 kernel bootarg.
Partial-Bug: 1860193
Depends-On: https:/
Change-Id: Iaa11ba3f430fc0
Signed-off-by: Jim Somerville <email address hidden>
commit 83775d38804fb66
Author: David Sullivan <email address hidden>
Date: Wed Jan 15 23:50:23 2020 -0500
Install secondary controller nodes with kubeadm join
Kubeadm init is no longer supported for installing secondary nodes in an
HA kubernetes cluster. kubeadm join with the --controller-plane option
should be used.
Change-Id: I21a30b9e871d05
Closes-Bug: 1846829
Depends-On: https:/
Signed-off-by: David Sullivan <email address hidden>
commit c94fa4a0174b96e
Author: Shuicheng Lin <email address hidden>
Date: Thu Jan 23 02:45:31 2020 +0800
Fix duplex system controller-1 fail to boot after unlock
It is due to controller-1 doesn't have /opt/platform/
And cause puppet failure due to using non-exist file as source.
Restrict the code for worker node only, since controller node
already has ca cert in the ssl folder.
Test:
Pass simplex/
Closes-Bug: 1860529
Change-Id: I808ee15e5c78eb
Signed-off-by: Shuicheng Lin <email address hidden>
commit 27f167eb14a04bc
Author: Angie Wang <email address hidden>
Date: Wed Jan 15 16:15:26 2020 -0500
Remove puppet-manifests code made obsolete by ansible
As a result of switch to Ansible, remove the obsolete erb
templates and remove the dependency of is_initial_
facter.
Change-Id: I4ca6525f01a37d
Partial-Bug: 1834218
Depends-On: https:/
...
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (f/centos8) | #19 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: f/centos8
commit 1f0706ee30f44c6
Author: Don Penney <email address hidden>
Date: Mon Feb 3 12:48:03 2020 -0500
Drop clone.py references from boot menu comment blocks
As part of recent code cleanup activities, the controllerconfig
clone.py module was dropped. This update removes references to this
file from the comment blocks of the boot menu files grub.cfg and
centos.
Change-Id: If2260c74f58a61
Partial-Bug: 1834218
Signed-off-by: Don Penney <email address hidden>
commit 91f488af02e2bc2
Author: Jim Somerville <email address hidden>
Date: Mon Jan 27 17:18:47 2020 -0500
Security: Handle nospectre_v1 in the bootargs
Most of the v1 mitigation is baked into the kernel and not
optional. The swapgs barriers are, however, optional.
They have a negative performance impact so we disable them
by using the nospectre_v1 kernel bootarg.
Partial-Bug: 1860193
Depends-On: https:/
Change-Id: Id11232fe113293
Signed-off-by: Jim Somerville <email address hidden>
commit eff0d663776587a
Author: Angie Wang <email address hidden>
Date: Mon Jan 20 15:09:10 2020 -0500
Remove unused post_clone_
Change-Id: I3be9384b94473c
Partial-Bug: 1834218
Depends-On: https:/
Signed-off-by: Angie Wang <email address hidden>
commit 4609dacc5f2ffa5
Author: Eric MacDonald <email address hidden>
Date: Mon Jan 20 11:34:07 2020 -0500
Fix rvmc container build
The current rvmc container build has a conflict over the
python3-pip install.
The CentOS repo has a prior version of python3-pip that
requires python3 3.6 but the CENGN repo requires 3.7 due
to the Titanium base image.
The issue is resolved by updating this dockerfile with an
older verison of python3-pip.
Also, Since python3-pip provides pip3 the explicit pip3
install is no longer required.
Change-Id: Ic0cf0d070eaa8f
Story: 2006980
Task: 37775
Signed-off-by: Eric MacDonald <email address hidden>
commit a9a2ca64bc409dd
Author: Saul Wold <email address hidden>
Date: Wed Jan 15 19:22:09 2020 -0800
rvmc: remove un-used build data
The error below reported in the build logs because rvmc is not
setup to be built as an RPM package.
ERROR: build_dir (425): Neither srpm_path nor .spec file not found
in '/localdisk/
Closes-Bug: 1859893
Change-Id: I9b2788bb227afb
Signed-off-by: Saul Wold <email address hidden>
commit d59ba5fdc21a895
Author: Al Baile...
code cleanup / no system impact, but should be done asap to remove dead code and avoid confusion.