Fail to assign IP addresses to data interfaces

[Yosief Gebremariam]

Brief Description
-----------------
Assigning IP addresses to a data interface on VXLAN provider network failed.

Severity
--------
Major

Steps to Reproduce
------------------
Install controller-0
Run ansible-playbook to configure controller-0
Add data networks
Add interfaces on controller-0
Add IP addresses and routes to data interfaces on controller-0

Expected Behavior
------------------
IP addresses and routes assigned successfully

Actual Behavior
----------------
Setting up data addresses for data interface on controller-0 failed

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-DX with VXLAN configuration

Branch/Pull Time/Commit
-----------------------
master 20190614T013000Z

Last Pass
---------
master 20190613T013000Z

Timestamp/Logs
--------------
2019-06-14 15:38:15 Stage complete: vswitch_cpus
2019-06-14 15:38:17 found VXLAN provider networks: group0-data1
2019-06-14 15:38:17 Adding IP addresses and routes to data interfaces on controller-0
2019-06-14 15:38:19 Adding addresses: interfaces mgmt0|[] oam0|[] data0|[u'group0-data0'] data1|[u'group0-data1']
2019-06-14 15:38:19 Setting up data addresses for data1 on controller-0: 192.168.78.98/24
2019-06-14 15:38:21 [admin@admin]> RUNNING: system host-if-modify controller-0 data1 --ipv4-mode=static
Address mode attributes only supported on 'mgmt, oam, cluster-host, data, ironic' interfaces
2019-06-14 15:38:23 COMMAND FAILED (rc=1): system host-if-modify controller-0 data1 --ipv4-mode=static
2019-06-14 15:38:23 ===========================
2019-06-14 15:38:23 Check "/home/sysadmin/lab_setup.group0.log" for more details, and re-run the failed
2019-06-14 15:38:23 command manually before contacting the domain owner for assistance.
2019-06-14 16:32:05 ============================================================================
2019-06-14 16:32:05 Starting lab setup (/home/sysadmin/lab_setup.conf): Fri Jun 14 16:32:05 UTC 2019

[Ghada Khalil (gkhalil)]

Marking as stx.2.0 gating; issue introduced by recent changes to interface cmds

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665468

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665468
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=4c1764f82f5387391501e8fdbd576083c3b14bda
Submitter: Zuul
Branch: master

commit 4c1764f82f5387391501e8fdbd576083c3b14bda
Author: Teresa Ho <email address hidden>
Date: Fri Jun 14 13:12:43 2019 -0400

    Fix IP address assignment to data interface

    This commit fixes the issue with changing ipv4 mode and assigning
    static IP address to data interface.

    Closes-Bug: 1832898

    Change-Id: I91de87fa518f4776fa12f7b18b93d7b05eb99009
    Signed-off-by: Teresa Ho <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665666

[Ghada Khalil (gkhalil)]

Re-opening as an additional fix is required

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665666
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=0f08838031c6cc6e55db2673ca0e8d1e977fafe2
Submitter: Zuul
Branch: master

commit 0f08838031c6cc6e55db2673ca0e8d1e977fafe2
Author: Teresa Ho <email address hidden>
Date: Mon Jun 17 09:09:20 2019 -0400

    Fix IP address assignment validation

    This commit corrects the validation of IP address assignment.

    Closes-Bug: 1832898

    Change-Id: I1ead991911f7403b08dc15491b73f1769e5c5d56
    Signed-off-by: Teresa Ho <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665980

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665980
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=f26fb2a11406d9b271946d193fd338a403acee83
Submitter: Zuul
Branch: master

commit f26fb2a11406d9b271946d193fd338a403acee83
Author: Teresa Ho <email address hidden>
Date: Mon Jun 17 16:46:05 2019 -0400

    Added tox tests for IP address mode

    This commit added tox tests for IP address mode validation.

    Closes-Bug: 1832898

    Change-Id: Iaa685eceaf56c090f1a575e1148bff1de3375d67
    Signed-off-by: Teresa Ho <email address hidden>