application-update command not proceeding ('KubeAppController' object has no attribute '_check_environment')

[Wendy Mitchell]

Brief Description
-----------------
system application-update command immediately returning
'KubeAppController' object has no attribute '_check_environment'

Severity
--------
Major

Steps to Reproduce
------------------
1. installed stx (with vswitch type ovs-dpdk) but did not apply stx-openstack application (Note: labels added to worker nodes)
2. Performed system application-apply (selecting the versioned tarfile for stx-openstack)
system application-apply was reported as successfully completed (no pods failing)

$ system application-list
+---------------------+--------------------------------+-------------------------------+--------------------+---------+-----------+
| application | version | manifest name | manifest file | status | progress |
+---------------------+--------------------------------+-------------------------------+--------------------+---------+-----------+
| platform-integ-apps | 1.0-7 | platform-integration-manifest | manifest.yaml | applied | completed |
| stx-openstack | 1.0-14-centos-stable-versioned | armada-manifest | stx-openstack.yaml | applied | completed

3. attempt system application-update to centos-stable-latest stx-openstack-1.0-14-centos-stable-latest.tgz
eg. $ system application-update -n stx-openstack -v 1.0-14-centos-stable-latest stx-openstack-1.0-14-centos-stable-latest.tgz
(or $ system application-update stx-openstack-1.0-14-centos-stable-latest.tgz)

Expected Behaviour
------------------
Expect update to proceed and updating status to be reported from command $system application-list

Actual Behaviour
----------------

the cli command returned the following instead
'KubeAppController' object has no attribute '_check_environment'

sysinv.log
2019-06-13 17:51:08.249 108898 ERROR wsme.api [-] Server-side error: "'KubeAppController' object has no attribute '_check_environment'". Detail:
Traceback (most recent call last):

File "/usr/lib/python2.7/site-packages/wsmeext/pecan.py", line 85, in callfunction
result = f(self, args, *kwargs)

File "/usr/lib64/python2.7/site-packages/sysinv/api/controllers/v1/kube_app.py", line 302, in update
self._check_environment()

AttributeError: 'KubeAppController' object has no attribute '_check_environment'

Reproducibility
---------------
yes

System Configuration
--------------------
2+2 system

Branch/Pull Time/Commit
-----------------------
BUILD_ID="20190613T013000Z"

Timestamp/Logs
--------------see sysinv.log error above

[Wendy Mitchell (wmitchellwr)]

Thought to be related to this:
https://opendev.org/starlingx/config/commit/9982198d020ea434fce4d8301f1345fc0ec4c98a

[Al Bailey (albailey1974)]

https://review.opendev.org/#/c/665201/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665201
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=fba5c851e6a7f79f0a90e9bb1d63cea32b4189a0
Submitter: Zuul
Branch: master

commit fba5c851e6a7f79f0a90e9bb1d63cea32b4189a0
Author: Al Bailey <email address hidden>
Date: Thu Jun 13 13:11:05 2019 -0500

    Remove a call to a removed check_environment function

    This is a merge issue between a review that added a new method
    and was calling a utility method that was removed by another review.

    The two conflicting reviews were:
     https://review.opendev.org/#/c/663783/
     https://review.opendev.org/#/c/662838/

    This also cleans up an unused function.

    Closes-Bug: 1832756
    Change-Id: Id10f9b5a2162713e47c926df7943491c952bcf68
    Signed-off-by: Al Bailey <email address hidden>

[Wendy Mitchell (wmitchellwr)]

Ignore previous verified comment. Needs to be tested on a newer build.

[Wendy Mitchell (wmitchellwr)]

verified
BUILD_ID="20190617T233000Z"

[Ghada Khalil (gkhalil)]

Marking as stx.2.0 release gating; issue with new application-update cmd; caused by a merge conflict.