Host unlock is failing with the error helm_override_get

[Anujeyan Manokeran]

Brief Description
-----------------.
    When compute was locked and unlocked Host unlock is failing with the error helm_override_get() takes exactly 4 arguments (3 given).

system --os-username 'admin' --os-password 'Li69nux*' --os-project-name admin --os-auth-url http://192.168.204.2:5000/v3 --os-user-domain-name Default --os-project-domain-name Default --os-endpoint-type internalURL --os-region-name RegionOne host-lock compute-1'

     Send 'system --os-username 'admin' --os-password 'Li69nux*' --os-project-name admin --os-auth-url http://192.168.204.2:5000/v3 --os-user-domain-name Default --os-project-domain-name Default --os-endpoint-type internalURL --os-region-name RegionOne host-unlock compute-1'
[2019-06-09 17:00:40,483] 387 DEBUG MainThread ssh.expect :: Output:
helm_override_get() takes exactly 4 arguments (3 given)
Traceback (most recent call last):

Severity
--------.
Major
Steps to Reproduce
------------------
1. system --os-username 'admin' --os-password 'Li69nux*' --os-project-name admin --os-auth-url http://192.168.204.2:5000/v3 --os-user-domain-name Default --os-project-domain-name Default --os-endpoint-type internalURL --os-region-name RegionOne host-lock compute-1'
2. 'system --os-username 'admin' --os-password 'Li69nux*' --os-project-name admin --os-auth-url http://192.168.204.2:5000/v3 --os-user-domain-name Default --os-project-domain-name Default --os-endpoint-type internalURL --os-region-name RegionOne host-cpu-modify -f vswitch -p2 1 compute-1'

3. 'system --os-username 'admin' --os-password 'Li69nux*' --os-project-name admin --os-auth-url http://192.168.204.2:5000/v3 --os-user-domain-name Default --os-project-domain-name Default --os-endpoint-type internalURL --os-region-name RegionOne host-unlock compute-1'
[2019-06-09 17:00:40,483] 387 DEBUG MainThread ssh.expect :: Output:
helm_override_get() takes exactly 4 arguments (3 given)
Traceback (most recent call last):

Expected Behavior
------------------
No failure on unlock compute

Actual Behavior
----------------
Unlock compute failure as per description
Reproducibility
---------------
100% reproducible
System Configuration
--------------------
Regular system
Branch/Pull Time/Commit
-----------------------
BUILD_DATE=20190608T015935Z
Last Pass
---------
Timestamp/Logs
--------------
2019-06-09 17:00:40,483
Test Activity
-------------
Regression test

[Al Bailey (albailey1974)]

Review is up to address this:
https://review.opendev.org/#/c/664263/

[Ghada Khalil (gkhalil)]

Marking as release gating; critical as this impacts sanity

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664263
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=22cfb0e699582150d32338ec3ffd49b26b317c06
Submitter: Zuul
Branch: master

commit 22cfb0e699582150d32338ec3ffd49b26b317c06
Author: Al Bailey <email address hidden>
Date: Mon Jun 10 09:23:50 2019 -0500

    Fix sanity issue during controller unlock

    A recent commit merged without rebasing to a new method signature
     https://review.opendev.org/#/c/657383/

    This impacts the ability to do a host-unlock in certain
    scenarios.

    Change-Id: Ia5d71689c79762f7fcdcd0734c205f73e983cdf0
    Closes-Bug: 1832237
    Signed-off-by: Al Bailey <email address hidden>

[Wendy Mitchell (wmitchellwr)]

BUILD_ID="20190611T000451Z"
verified - no longer seeing the error describe above
Lock/unlock of the worker node no longer gets this error