Worker node with more than 1 sriov/vfio interface fails to enable

[Brent Rowsell]

Brief Description
-----------------
I provisioned a worker node with 2 sr-iov interfaces with the vfio driver. The node failed to enable
Manifest is failing to apply

2019-05-30T01:45:09.036 ^[[0;36mDebug: 2019-05-30 01:45:08 +0000 template[/usr/share/puppet/modules/platform/templates/partitions.manage.erb]: Bound template variables for /usr/share/puppet/modules/platform/templates/partitions.manage.erb in 0.00 seconds^[[0m
2019-05-30T01:45:09.038 ^[[0;36mDebug: 2019-05-30 01:45:08 +0000 template[/usr/share/puppet/modules/platform/templates/partitions.manage.erb]: Interpolated template /usr/share/puppet/modules/platform/templates/partitions.manage.erb in 0.00 seconds^[[0m
2019-05-30T01:45:09.040 ^[[0;36mDebug: 2019-05-30 01:45:08 +0000 Scope(Platform::Interfaces::Sriov_config[sriov0]): Retrieving template platform/sriov.bind-device.erb^[[0m
2019-05-30T01:45:09.042 ^[[0;36mDebug: 2019-05-30 01:45:08 +0000 template[/usr/share/puppet/modules/platform/templates/sriov.bind-device.erb]: Bound template variables for /usr/share/puppet/modules/platform/templates/sriov.bind-device.erb in 0.00 seconds^[[0m
2019-05-30T01:45:09.044 ^[[0;36mDebug: 2019-05-30 01:45:08 +0000 template[/usr/share/puppet/modules/platform/templates/sriov.bind-device.erb]: Interpolated template /usr/share/puppet/modules/platform/templates/sriov.bind-device.erb in 0.00 seconds^[[0m
2019-05-30T01:45:09.046 ^[[1;31mError: 2019-05-30 01:45:08 +0000 Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Exec[load vfio-pci] is already declared in file /usr/share/puppet/modules/platform/manifests/network.pp:118; cannot redeclare at /usr/share/puppet/modules/platform/manifests/network.pp:118 at /usr/share/puppet/modules/platform/manifests/network.pp:118:5 on node worker-3

Severity
--------
Major

Steps to Reproduce
------------------
See above

Expected Behavior
------------------
Node should enable

Actual Behavior
----------------
See above

Reproducibility
---------------
100%

System Configuration
--------------------
All

Branch/Pull Time/Commit
-----------------------
2019-05-29 17:08:35 -0400

Last Pass
---------
N/A, new functionality

Timestamp/Logs
--------------
See above

Test Activity
-------------
Other

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/662307

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662307
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=337feafe531cc9861f1dddcada4098d2092ca94c
Submitter: Zuul
Branch: master

commit 337feafe531cc9861f1dddcada4098d2092ca94c
Author: Steven Webster <email address hidden>
Date: Thu May 30 11:06:42 2019 -0500

    Fix: Duplicate puppet resource for SR-IOV VF driver

    This commit fixes a bug which can be seen if more than one interface
    is configured with the same SR-IOV VF driver.

    In this case a duplicate puppet resource error will occur after host
    unlock.

    Closes-Bug: #1831077
    Change-Id: I7eeedfdbba62e1a0c71ce367bd717fdafb44ca63
    Signed-off-by: Steven Webster <email address hidden>