installation from an iso does not automatically enable any network interfaces; ONBOOT=no

[Allain Legacy]

Brief Description
-----------------
Installation from an ISO does not configure any network interfaces to automatically be enabled on reboots. The /etc/sysconfig/network-scripts/ifcfg-* scripts exist but are all set as ONBOOT=no. This forces an end-user to have to manually access the target via the console in order to enable a network interface so that it can be configured using a remote tool chain (i.e., Ansible).

Severity
--------
Major, limits a hands-off integration into a CI/CD automated pipeline.

Steps to Reproduce
------------------
Install from an ISO via local USB or remotely mounted ISO via BMC.

Expected Behavior
------------------
If the OAM network is configured to provide an IP address to the node that was booted via USB then the node should acquire an IP address and be accessible over the network once the install completes.

Actual Behavior
----------------
The /etc/sysconfig/network-scripts/ifcfg-* files are automatically created but are all set as ONBOOT=no; therefore, none of the network interfaces are enabled automatically.

Reproducibility
---------------
100%

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
20190522T013000Z

Last Pass
---------
Unknown

Timestamp/Logs
--------------
n/a

Test Activity
-------------
Developer testing

[Ghada Khalil (gkhalil)]

Marking as release gating as this limits remote configuration

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/661060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/661060
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=fa505bfb78994b9ee7b7b2e26e6b89753141afce
Submitter: Zuul
Branch: master

commit fa505bfb78994b9ee7b7b2e26e6b89753141afce
Author: Don Penney <email address hidden>
Date: Thu May 23 12:40:00 2019 -0400

    Set ONBOOT=yes for NICs on install from USB

    Update the ifcfg file for all network devices in
    a %post in the USB kickstart to set ONBOOT=yes.
    This allows network interfaces to attempt DHCP
    after initial installation, in order to automatically
    be enabled and accessible (depending on network
    configuration).

    Change-Id: Icaabcd2111e44a5bf2326aee0267b775af95933e
    Closes-Bug: 1830035
    Signed-off-by: Don Penney <email address hidden>