Semantic check slowing down the storage infrastructure deployment

[Ovidiu Poncea]

Brief Description
-----------------
In 2+2+2, we should allow unlocking worker even if storage nodes are not in 'available' state.

@Brent: Given the applications are decoupled from the infrastructure, we should remove this check. This unnecessarily slows down the infrastructure deployment.

Message displayed to user:

Error: Unable to unlock hosts: compute-1, compute-2, compute-3. Reason/Action: Can not unlock a worker node until at least one storage node is unlocked and enabled.

Severity
--------
Minor: Deployment workflow improvement

Steps to Reproduce
------------------
1. Install in standard mode till both controller are available. Do not configure OSDs.
2. Install worker nodes, do not configure worker node but skip ceph-mon configuration on worker node and do not install any storage nodes.
3. Unlock any worker node

Expected Behavior
------------------
If ceph-mon is configured on any worker node we allow unlocking workers
If there is any node of storage personality we allow unlocking worker nodes
=> Unlocking workers is denied only if there is no certainty about storage model used so that we force users into adding a ceph mon to the cluster.

Reproducibility
---------------
<Reproducible/Intermittent>
State if the issue is 100% reproducible or intermittent. If it is intermittent, state the frequency of occurrence

System Configuration
--------------------
Multi-node system, Dedicated storage

[Ghada Khalil (gkhalil)]

I believe this was already reported by Brent in https://bugs.launchpad.net/starlingx/+bug/1829765

[Ovidiu Poncea (ovidiuponcea)]

Yeah, indeed, I marked it as duplicate.

[Ghada Khalil (gkhalil)]

Marking as release gating; deployment needs to be optimized and aligned across the different configs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/666537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666537
Committed: https://git.openstack.org/cgit/starlingx/config/commit/?id=b8f37f61f92cc3540baae4fe39a15b82bb6bcb38
Submitter: Zuul
Branch: master

commit b8f37f61f92cc3540baae4fe39a15b82bb6bcb38
Author: Ovidiu Poncea <email address hidden>
Date: Thu Jun 20 13:48:37 2019 +0300

    Allow unlocking workers even if storage nodes are not yet available

    To speed up infrastructure deployment we allow unlocking workers if
    any storage node is configured. Before this change user had to wait
    for storage nodes to be available.

    Also, when user tries to unlock a worker but the storage deployment
    model is undefined a proper message is displayed.

    Change-Id: I548c4b06b646a1bf22ba6207735f050b16a62efe
    Closes-Bug: 1829844
    Signed-off-by: Ovidiu Poncea <email address hidden>