system host-unlock controller-1 fails

[Cristopher Lemus]

Brief Description
-----------------
During sanity execution for ISO: http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/20190509T013000Z/outputs/iso/bootimage.iso , "system host-unlock controller-1" command fails.

Severity
--------
Critical: Cannot complete standard and standard external configurations.

Steps to Reproduce
------------------
Follow up wiki instructions for any of the standard configurations. It fails on this step: https://wiki.openstack.org/wiki/StarlingX/Containers/InstallationOnStandard#Unlock_Controller-1

Expected Behavior
------------------
Second controller (controller-1) should be unlocked.

Actual Behavior
----------------
Instead of unlocking, received the following error:

[wrsroot@controller-0 ~(keystone_admin)]$ system host-unlock controller-1
unsupported operand type(s) for +=: 'int' and 'NoneType

Reproducibility
---------------
100% reproducible on standard configurations.

System Configuration
--------------------
Standard non-storage (2+2) and Standard storage (2+2+2)

Branch/Pull Time/Commit
-----------------------
ISO: http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/20190509T013000Z/outputs/iso/bootimage.iso
controller-0:~$ cat /etc/build.info
###
### StarlingX
### Built from master
###

OS="centos"
SW_VERSION="19.01"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="20190509T013000Z"

JOB="STX_build_master_master"
<email address hidden>"
BUILD_NUMBER="95"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2019-05-09 01:30:00 +0000"

Last Pass
---------
2019-05-08 passed this step.

Timestamp/Logs
--------------
[wrsroot@controller-0 ~(keystone_admin)]$ system host-unlock controller-1
unsupported operand type(s) for +=: 'int' and 'NoneType'
Traceback (most recent call last):

  File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/amqp.py", line 438, in _process_data
    **args)

  File "/usr/lib64/python2.7/site-packages/sysinv/openstack/common/rpc/dispatcher.py", line 172, in dispatch
    result = getattr(proxyobj, method)(ctxt, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 1587, in configure_ihost
    self._configure_controller_host(context, host)

  File "/usr/lib64/python2.7/site-packages/sysinv/conductor/manager.py", line 1324, in _configure_controller_host
    self._puppet.update_host_config(host)

  File "/usr/lib64/python2.7/site-packages/sysinv/puppet/puppet.py", line 30, in _wrapper
    func(self, *args, **kwargs)

  File "/usr/lib64/python2.7/site-packages/sysinv/puppet/puppet.py", line 145, in update_host_config
    config.update(puppet_plugin.obj.get_host_config(host))

  File "/usr/lib64/python2.7/site-packages/sysinv/puppet/kubernetes.py", line 78, in get_host_config
    config.update(self._get_host_k8s_cgroup_config(host))

  File "/usr/lib64/python2.7/site-packages/sysinv/puppet/kubernetes.py", line 160, in _get_host_k8s_cgroup_config
    k8s_reserved_mem += memory[0].platform_reserved_mib

TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

[wrsroot@controller-0 ~(keystone_admin)]$

Full collect attached to bug.

Test Activity
-------------
Sanity

[Bart Wensley (bartwensley)]

The code throwing the exception seems to have been introduced by: https://opendev.org/starlingx/config/commit/5b4ae7503780873552648746f3c9885eb5741014

[Ghada Khalil (gkhalil)]

Marking as release gating; sanity issue introduced by recent submission

[Ghada Khalil (gkhalil)]

Fixed by: https://review.opendev.org/#/c/658157/

[Ghada Khalil (gkhalil)]

Merged on May 9