sm-dump output not formatted properly

Bug #1828045 reported by Anujeyan Manokeran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Hayde Martinez

Bug Description

Brief Description
-----------------
      It was noticed the sm-dum output is changed process id and filename are attached together which is not the case in older loads. See below pid and pid file. I have the older sm-dump which is not combine which is clear and easy to read. This is causing the automation to fail on process monitoring test case also the output doesn’t good as before in format .This is very minor bug.

sudo sm-dump --impact --pid --pid_file
Password:

-Service_Groups------------------------------------------------------------------------
oam-services active active
controller-services active active
cloud-services active active
patching-services active active
directory-services active active
web-services active active
storage-services active active
storage-monitoring-services active active
vim-services active active
---------------------------------------------------------------------------------------

-Services-----------------------------------------------------------------------------------------------------------------------------
oam-ip enabled-active enabled-active critical
management-ip enabled-active enabled-active critical
drbd-pg enabled-active enabled-active critical
drbd-rabbit enabled-active enabled-active critical
drbd-cgcs enabled-active enabled-active critical
drbd-platform enabled-active enabled-active critical
pg-fs enabled-active enabled-active critical
rabbit-fs enabled-active enabled-active critical
nfs-mgmt enabled-active enabled-active critical
cgcs-fs enabled-active enabled-active critical
platform-fs enabled-active enabled-active critical
postgres enabled-active enabled-active critical 2239409/var/run/postmaster.pid
rabbit enabled-active enabled-active critical 2239450/var/run/rabbitmq/rabbitmq.pid
cgcs-export-fs enabled-active enabled-active critical
platform-export-fs enabled-active enabled-active critical
cgcs-nfs-ip enabled-active enabled-active critical
platform-nfs-ip enabled-active enabled-active critical
sysinv-inv enabled-active enabled-active critical 2242039/var/run/sysinv-api.pid
sysinv-conductor enabled-active enabled-active critical 2241420/var/run/sysinv-conductor.pid
mtc-agent enabled-active enabled-active critical 2242378/var/run/mtcAgent.pid
hw-mon enabled-active enabled-active critical 2242765/var/run/hwmond.pid
dnsmasq enabled-active enabled-active critical 2242002/var/run/dnsmasq.pid
fm-mgr enabled-active enabled-active critical 2241278/var/run/fmManager.pid
keystone enabled-active enabled-active critical 2241551/var/run/openstack-keystone.pid
open-ldap enabled-active enabled-active critical 120445 /var/run/slapd.pid
snmp enabled-active enabled-active critical 2242475/var/run/snmpd.pid
lighttpd enabled-active enabled-active critical 120675 /var/run/lighttpd.pid
horizon enabled-active enabled-active critical 120696 /var/run/openstack-dashboard.pid
patch-alarm-manager enabled-active enabled-active critical 2236669/var/run/patch-alarm-manager.pid
mgr-restful-plugin enabled-active enabled-active critical 120496 /var/run/ceph/mgr-restful-plugin.pid
ceph-manager enabled-active enabled-active critical 2236295/var/run/ceph/ceph-manager.pid
vim enabled-active enabled-active critical 2242708/var/run/nfv-vim.pid
vim-api enabled-active enabled-active critical 2243089/var/run/nfv-vim-api.pid
vim-webserver enabled-active enabled-active minor 2243090/var/run/nfv-vim-webserver.pid
guest-agent enabled-active enabled-active critical 2242728/var/run/guestAgent.pid
haproxy enabled-active enabled-active critical 2237776/var/run/haproxy.pid
pxeboot-ip enabled-active enabled-active critical
ceph-radosgw enabled-active enabled-active minor
drbd-extension enabled-active enabled-active critical
extension-fs enabled-active enabled-active critical
extension-export-fs enabled-active enabled-active critical
etcd enabled-active enabled-active critical 2238610/var/run/etcd.pid
drbd-etcd enabled-active enabled-active critical
etcd-fs enabled-active enabled-active critical
barbican-api enabled-active enabled-active critical 2241444/var/run/barbican/pid
barbican-keystone-listener enabled-active enabled-active critical 2243085/var/run/resource-agents/barbican-keystone-listener.pid
barbican-worker enabled-active enabled-active critical 2242709/var/run/resource-agents/barbican-worker.pid
cluster-host-ip enabled-active enabled-active critical
docker-distribution enabled-active enabled-active critical 2238518/var/run/docker-distribution.pid
dockerdistribution-fs enabled-active enabled-active critical
drbd-dockerdistribution enabled-active enabled-active critical
helmrepository-fs enabled-active enabled-active critical
registry-token-server enabled-active enabled-active critical 2237395/var/run/registry-token-server.pid
-----------------------------------------------------------------------------------------------------------------------------

Below display is from older load where Pid is not combine with pid file.

0:~$ sudo sm-dump --impact --pid --pid_file
Password:

-Service_Groups------------------------------------------------------------------------
oam-services active active
controller-services active active
cloud-services active active
patching-services active active
directory-services active active
web-services active active
vim-services active active
---------------------------------------------------------------------------------------

-Services-----------------------------------------------------------------------------------------------------------------------------
management-ip enabled-active enabled-active critical
drbd-pg enabled-active enabled-active critical
drbd-rabbit enabled-active enabled-active critical
drbd-cgcs enabled-active enabled-active critical
drbd-platform enabled-active enabled-active critical
pg-fs enabled-active enabled-active critical
rabbit-fs enabled-active enabled-active critical
nfs-mgmt enabled-active enabled-active critical
cgcs-fs enabled-active enabled-active critical
platform-fs enabled-active enabled-active critical
postgres enabled-active enabled-active critical 169644 /var/run/postmaster.pid
rabbit enabled-active enabled-active critical 169837 /var/run/rabbitmq/rabbitmq.pid
cgcs-export-fs enabled-active enabled-active critical
platform-export-fs enabled-active enabled-active critical
cgcs-nfs-ip enabled-active enabled-active critical
platform-nfs-ip enabled-active enabled-active critical
sysinv-inv enabled-active enabled-active critical 173656 /var/run/sysinv-api.pid
sysinv-conductor enabled-active enabled-active critical 171329 /var/run/sysinv-conductor.pid
mtc-agent enabled-active enabled-active critical 174187 /var/run/mtcAgent.pid
hbs-agent enabled-active enabled-active critical 174803 /var/run/hbsAgent.pid
hw-mon enabled-active enabled-active critical 174532 /var/run/hwmond.pid
dnsmasq enabled-active enabled-active critical 171678 /var/run/dnsmasq.pid
fm-mgr enabled-active enabled-active critical 170429 /var/run/fmManager.pid
keystone enabled-active enabled-active critical 171457 /var/run/openstack-keystone.pid
glance-registry enabled-active enabled-active critical 173290 /var/run/resource-agents/glance-registry.pid
glance-api enabled-active enabled-active critical 173604 /var/run/resource-agents/glance-api.pid
neutron-server enabled-active enabled-active critical 173221 /var/run/resource-agents/neutron-server.pid
nova-api enabled-active enabled-active critical 173945 /var/run/resource-agents/nova-api.pid
nova-scheduler enabled-active enabled-active critical 172916 /var/run/resource-agents/nova-scheduler.pid
nova-conductor enabled-active enabled-active critical 172798 /var/run/resource-agents/nova-conductor.pid
nova-console-auth enabled-active enabled-active critical 172309 /var/run/resource-agents/nova-console-auth.pid
nova-novnc enabled-active enabled-active minor 173998 /var/run/resource-agents/nova-novnc.pid
cinder-api enabled-active enabled-active critical 173779 /var/run/resource-agents/cinder-api.pid
cinder-scheduler enabled-active enabled-active critical 171711 /var/run/resource-agents/cinder-scheduler.pid
cinder-volume enabled-active enabled-active critical 171115 /var/run/resource-agents/cinder-volume.pid
ceilometer-collector enabled-active enabled-active critical 170654 /var/run/resource-agents/ceilometer-collector.pid
ceilometer-api enabled-active enabled-active critical 173347 /var/run/resource-agents/ceilometer-api.pid
ceilometer-agent-notification enabled-active enabled-active critical 174104 /var/run/resource-agents/ceilometer-agent-notification.pid
heat-engine enabled-active enabled-active critical 170662 /var/run/resource-agents/heat-engine.pid
heat-api enabled-active enabled-active critical 171643 /var/run/resource-agents/heat-api.pid
heat-api-cfn enabled-active enabled-active critical 172860 /var/run/resource-agents/heat-api-cfn.pid
heat-api-cloudwatch enabled-active enabled-active critical 173865 /var/run/resource-agents/heat-api-cloudwatch.pid
open-ldap enabled-active enabled-active critical 161999 /var/run/slapd.pid
snmp enabled-active enabled-active critical 172762 /var/run/snmpd.pid
lighttpd enabled-active enabled-active critical 167675 /var/run/lighttpd.pid
horizon enabled-active enabled-active critical 168416 /var/run/openstack-dashboard.pid
patch-alarm-manager enabled-active enabled-active critical 167926 /var/run/patch-alarm-manager.pid
drbd-cinder enabled-active enabled-active critical
cinder-lvm enabled-active enabled-active critical
iscsi enabled-active enabled-active critical
cinder-ip enabled-active enabled-active critical
vim enabled-active enabled-active critical 174336 /var/run/nfv-vim.pid
vim-api enabled-active enabled-active critical 175102 /var/run/nfv-vim-api.pid
vim-webserver enabled-active enabled-active minor 175044 /var/run/nfv-vim-webserver.pid
guest-agent enabled-active enabled-active critical 174465 /var/run/guestAgent.pid
nova-api-proxy enabled-active enabled-active critical 174991 /var/run/nova-api-proxy.pid
haproxy enabled-active enabled-active critical 168620 /var/run/haproxy.pid
pxeboot-ip enabled-active enabled-active critical
aodh-api enabled-active enabled-active critical 171381 /var/run/resource-agents/aodh-api.pid
aodh-evaluator enabled-active enabled-active critical 174053 /var/run/resource-agents/aodh-evaluator.pid
aodh-listener enabled-active enabled-active critical 170540 /var/run/resource-agents/aodh-listener.pid
aodh-notifier enabled-active enabled-active critical 173704 /var/run/resource-agents/aodh-notifier.pid
drbd-extension enabled-active enabled-active critical
extension-fs enabled-active enabled-active critical
extension-export-fs enabled-active enabled-active critical
panko-api enabled-active enabled-active critical 171594 /var/run/resource-agents/panko-api.pid
nova-placement-api enabled-active enabled-active critical 170566 /var/run/resource-agents/nova-placement-api.pid

Severity
--------
minor
Steps to Reproduce
------------------
1. Execute sudo sm-dump --impact --pid --pid_file and verify output between pid and pid file.
Expected Behavior
------------------
Sm-dump out put should be format properly
Actual Behavior
----------------
As per description sm-dump output not in right format
Reproducibility
---------------
100% reproducible.
System Configuration
--------------------
all the system
Branch/Pull Time/Commit
-----------------------
20190503T013000Z
Last Pass
---------
load 20190427T013000Z

Timestamp/Logs
--------------
Password:

Test Activity
-------------
Feature test

Tags: stx.ha
Revision history for this message
Bin Qian (bqian20) wrote :

64 bit Linux could have 7 digit PIDs. sm-dump has 7 characters for pid. Need to increase it to 8.

description: updated
description: updated
description: updated
Numan Waheed (nwaheed)
tags: added: stx.retestneeded
Revision history for this message
Ghada Khalil (gkhalil) wrote :

Minor display issue. Would be nice to fix, but not gating for any release.

tags: added: stx.ha
Changed in starlingx:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Bin Qian (bqian20)
Changed in starlingx:
assignee: Bin Qian (bqian20) → Hayde Martinez (haydemtz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ha (master)

Reviewed: https://review.opendev.org/661640
Committed: https://git.openstack.org/cgit/starlingx/ha/commit/?id=8cd6cc65f1bccf2056c11d87ce609b87b1cad484
Submitter: Zuul
Branch: master

commit 8cd6cc65f1bccf2056c11d87ce609b87b1cad484
Author: Hayde Martinez <email address hidden>
Date: Mon May 27 11:10:59 2019 -0500

    sm-dump output not formatted properly

    Using command: sudo sm-dump --impact --pid --pid_file
    pid column is not formatted properly and there is no space
    between pid and pid_file, this is due to pid's in linux can
    have up to 7 characters.

    This commit:
     a) Increases this field to 8 characters in order to fix format

    Test:
     Use "sudo sm-dump --impact --pid --pid_file"
    Closes-Bug: 1828045

    Change-Id: I3966f12f68c6694078f8670962c0d4113b8820c6
    Signed-off-by: Hayde Martinez <email address hidden>

Changed in starlingx:
status: Triaged → Fix Released
Revision history for this message
Anujeyan Manokeran (anujeyan) wrote :

Verified in load 20190617T233000Z

tags: removed: stx.retestneeded
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.