Can't add osd via Horizon for std system while unlocked

[Nimalini Rasa]

Brief Description
-----------------
Could not add osd using Horizon for controllers while unlocked while it is allowed using CLI.

Severity
--------
Provide the severity of the defect.
Minor: System/Feature is usable with minor issue, can be added via cli

Steps to Reproduce
------------------
Install the system and unlock controllers, try to add osd via horizon.

Expected Behavior
------------------
Should be able to add osd using Horizon

Actual Behavior
----------------
Blocked in Horizon

Reproducibility
---------------
100%

System Configuration
--------------------
Standard system (2+2)

Branch/Pull Time/Commit
-----------------------
OS="centos"
SW_VERSION="19.01"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="20190502T013000Z"

JOB="STX_build_master_master"
<email address hidden>"
BUILD_NUMBER="87"
BUILD_HOST="starlingx_mirror"
BUILD_DATE="2019-05-02 01:30:00 +0000"

Last Pass
---------
This is a newly added feature. Ability to add osd for unlocked host.

Test Activity
-------------
Platform Testing

[Ghada Khalil (gkhalil)]

Marking as release gating given the issue is related to a new feature - adding osds w/o locks

[Ghada Khalil (gkhalil)]

It would be nice if this is fixed asap to enable this functionality thru Horizon.

[Cindy Xie (xxie1)]

Can you please confirm if the issue still exist after Ceph upgrade? Need build after 5/3.

[Nimalini Rasa (nrasa)]

yes, the issue is there as of 2019-05-09 build

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/666571

[Bill Zvonar (billzvonar)]

Assigned to Bruce for re-assignment.

[Bruce Jones (brucej)]

I don't understand why this was assigned to me. It looks like there is a fix pending already. Is Ovidiu's patch not valid or does someone need to take that over?

[Ovidiu Poncea (ovidiuponcea)]

I have no idea why was this reassigned :) I took it back.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666571
Committed: https://git.openstack.org/cgit/starlingx/gui/commit/?id=bc78cb23a06cb6e5e5d697294ba7b653582e5ab3
Submitter: Zuul
Branch: master

commit bc78cb23a06cb6e5e5d697294ba7b653582e5ab3
Author: Ovidiu Poncea <email address hidden>
Date: Thu Jun 20 13:16:03 2019 +0000

    Fix addding OSDs for standard system while locked

    This commit allows adding OSDs at runtime to standard
    deployments with controller based storage w/o requiring
    controller nodes to be locked.

    Change-Id: I9c9052d1b9a1dc17b7be4db6d0514938f5af819c
    Closes-Bug: 1827514
    Signed-off-by: Ovidiu Poncea <email address hidden>

[Anujeyan Manokeran (anujeyan)]

Verified in build "20190827T033000Z" in a 2+2 system.